From: Rob Herring <robh@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>, Nishanth Menon <nm@ti.com>,
devicetree@vger.kernel.org, linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org, Viresh Kumar <vireshk@kernel.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PM / OPP: compatible is an optional property
Date: Fri, 23 Sep 2016 14:55:12 -0500 [thread overview]
Message-ID: <20160923195510.GA8699@rob-hp-laptop> (raw)
In-Reply-To: <20160923051526.GB17336@vireshk-i7>
On Fri, Sep 23, 2016 at 10:45:26AM +0530, Viresh Kumar wrote:
> On 22-09-16, 12:24, Stephen Boyd wrote:
> > On 09/21/2016 02:32 AM, Viresh Kumar wrote:
> > > It was never compulsory to have a compatible string in the OPP table.
> > > Fix the documentation to mark it optional.
> > >
NAK.
> > > Also update its description a bit.
> > >
> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > > ---
> >
> > Why? I'd prefer the compatible string to be required so we know what
> > sort of node it is.
Agreed.
> Okay, the code doesn't have any checks for it then and that needs to be fixed.
Why? The kernel is not a DT validator.
> Just for my clarity, for platforms with special OPP bindings and so a different
> compatible string like: "operating-points-v2-XYZ", should the compatible string
> contain both "operating-points-v2" and the above one? It would be easier to
> check for "operating-points-v2" in that case from core code.
That would imply operating-points-v2-XYZ has extra properties or is
different in some way. If an OS only understanding operating-points-v2
will work, then yes it should have both. If not, then no.
Rob
next prev parent reply other threads:[~2016-09-23 19:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 9:32 Viresh Kumar
2016-09-21 9:32 ` [PATCH 2/2] PM / OPP: Multiple regulators aren't supported yet Viresh Kumar
2016-09-23 19:59 ` Rob Herring
2016-09-26 5:07 ` Viresh Kumar
2016-09-22 19:24 ` [PATCH 1/2] PM / OPP: compatible is an optional property Stephen Boyd
2016-09-23 5:15 ` Viresh Kumar
2016-09-23 19:55 ` Rob Herring [this message]
2016-09-26 4:55 ` Viresh Kumar
2016-09-23 6:48 ` [PATCH V2 1/2] PM / OPP: compatible string is not optional Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923195510.GA8699@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome