From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759185AbcIWVai (ORCPT ); Fri, 23 Sep 2016 17:30:38 -0400 Received: from mail-yw0-f174.google.com ([209.85.161.174]:33991 "EHLO mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbcIWVac (ORCPT ); Fri, 23 Sep 2016 17:30:32 -0400 Date: Fri, 23 Sep 2016 17:30:30 -0400 From: Tejun Heo To: zijun_hu Cc: zijun_hu@htc.com, Andrew Morton , "linux-kernel@vger.kernel.org" , linux-mm@kvack.org, cl@linux.com Subject: Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for pcpu_embed_first_chunk() Message-ID: <20160923213030.GG31387@htj.duckdns.org> References: <7180d3c9-45d3-ffd2-cf8c-0d925f888a4d@zoho.com> <20160923192351.GE31387@htj.duckdns.org> <39277252-5bf4-b355-c076-8059e693f4aa@zoho.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39277252-5bf4-b355-c076-8059e693f4aa@zoho.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Sat, Sep 24, 2016 at 05:16:56AM +0800, zijun_hu wrote: > On 2016/9/24 3:23, Tejun Heo wrote: > > On Sat, Sep 24, 2016 at 02:20:24AM +0800, zijun_hu wrote: > >> From: zijun_hu > >> > >> correct max_distance from (base of the highest group + ai->unit_size) > >> to (base of the highest group + the group size) > >> > >> Signed-off-by: zijun_hu > > > > Nacked-by: Tejun Heo > > > > Thanks. > > > frankly, the current max_distance is error, doesn't represents the ranges spanned by > areas owned by the groups I think you're right but can you please update the patch description so that it explains what the bug and the implications are and how the patch fixes the bug. Also, please make sure that all changes made by the patch are explained in the description - e.g. why the type of @max_distance is changed from size_t to ulong. Thanks. -- tejun