From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761223AbcIWWhw (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Sep 2016 18:37:52 -0400
Received: from mail-oi0-f65.google.com ([209.85.218.65]:36656 "EHLO
        mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753106AbcIWWht (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Sep 2016 18:37:49 -0400
Date: Fri, 23 Sep 2016 17:37:48 -0500
From: Rob Herring <robh@kernel.org>
To: Nava kishore Manne <nava.manne@xilinx.com>
Cc: gregkh@linuxfoundation.org, mark.rutland@arm.com, jslaby@suse.com,
        michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
        linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        punnaia@xilinx.com, Nava kishore Manne <navam@xilinx.com>
Subject: Re: [PATCH v4] devicetree: bindings: uart: Add new compatible string
 for ZynqMP
Message-ID: <20160923223747.GA1163@rob-hp-laptop>
References: <1474629948-9780-1-git-send-email-navam@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1474629948-9780-1-git-send-email-navam@xilinx.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 23, 2016 at 04:55:48PM +0530, Nava kishore Manne wrote:
> From: Nava kishore Manne <nava.manne@xilinx.com>
> 
> This patch Adds the new compatible string for ZynqMP.
> 
> Signed-off-by: Nava kishore Manne <navam@xilinx.com>
> ---
> Changes for v4:
> 		-Modified the ChangeLog comment.
> Changes for v3:
> 		-Added changeLog comment.
> Changes for v2:
>                 -None
> 
>  Documentation/devicetree/bindings/serial/cdns,uart.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/cdns,uart.txt b/Documentation/devicetree/bindings/serial/cdns,uart.txt
> index a3eb154..4fe7aae 100644
> --- a/Documentation/devicetree/bindings/serial/cdns,uart.txt
> +++ b/Documentation/devicetree/bindings/serial/cdns,uart.txt
> @@ -1,7 +1,8 @@
>  Binding for Cadence UART Controller
>  
>  Required properties:
> -- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps"
> +- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps" for Zynq and
> +               "cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC uart controller.

Please format this as one valid combination per line.

xuartps is not very specific. It needs some abbreviation of "Zynq 
Ultrascale+ MPSoC" in it.

>  - reg: Should contain UART controller registers location and length.
>  - interrupts: Should contain UART controller interrupts.
>  - clocks: Must contain phandles to the UART clocks
> -- 
> 2.1.2
>