From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941452AbcIZDk1 (ORCPT ); Sun, 25 Sep 2016 23:40:27 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:55118 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932234AbcIZDk0 (ORCPT ); Sun, 25 Sep 2016 23:40:26 -0400 Date: Sun, 25 Sep 2016 23:40:12 -0400 (EDT) Message-Id: <20160925.234012.933201102491235169.davem@davemloft.net> To: colin.king@canonical.com Cc: hariprasad@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2] cxgb4: fix -ve error check on a signed iq From: David Miller In-Reply-To: <20160925211445.11234-1-colin.king@canonical.com> References: <20160925211445.11234-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 25 Sep 2016 20:40:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Sun, 25 Sep 2016 14:14:45 -0700 > From: Colin Ian King > > iq is unsigned, so the error check for iq < 0 has no effect so errors > can slip past this check. Fix this by making iq signed and also > get_filter_steerq return a signed int so a -ve error can be returned. > > Signed-off-by: Colin Ian King Applied, thanks.