From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761531AbcIYUeb (ORCPT <rfc822;w@1wt.eu>);
        Sun, 25 Sep 2016 16:34:31 -0400
Received: from mail-wm0-f68.google.com ([74.125.82.68]:35101 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756166AbcIYUe3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 25 Sep 2016 16:34:29 -0400
Date: Sun, 25 Sep 2016 22:34:25 +0200
From: Daniel Vetter <daniel@ffwll.ch>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Daniel Vetter <daniel@ffwll.ch>, Brian Starkey <brian.starkey@arm.com>,
        Liviu Dudau <Liviu.Dudau@arm.com>, Sean Paul <seanpaul@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i2c: tda998x: don't register the connector
Message-ID: <20160925203425.GN20761@phenom.ffwll.local>
Mail-Followup-To: Russell King - ARM Linux <linux@armlinux.org.uk>,
        Brian Starkey <brian.starkey@arm.com>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        Sean Paul <seanpaul@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
References: <20160922103917.GA5632@e106950-lin.cambridge.arm.com>
 <20160922105155.GT1041@n2100.armlinux.org.uk>
 <CAOw6vbL+-J1mcSvheTF99GNgGBdLbDH-oxAELB3XVDTw-v+2fg@mail.gmail.com>
 <20160922141404.GA5222@e106950-lin.cambridge.arm.com>
 <CAKMK7uHjB8KPsaToZsgn9Hh3L4BsEBoYUZPosCsMpWW+7ie-BQ@mail.gmail.com>
 <20160923093416.GU8917@e106497-lin.cambridge.arm.com>
 <CAKMK7uF7o59A=++R4kykSusfwEV5vSWWCswN6Gp9O_LcrdiQ-A@mail.gmail.com>
 <20160923125248.GA23321@e106950-lin.cambridge.arm.com>
 <20160923131315.GI3988@dvetter-linux.ger.corp.intel.com>
 <20160923140503.GY1041@n2100.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160923140503.GY1041@n2100.armlinux.org.uk>
X-Operating-System: Linux phenom 4.6.0-1-amd64 
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 23, 2016 at 03:05:03PM +0100, Russell King - ARM Linux wrote:
> On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote:
> > Hm, maybe we should simply not call ->lastclose for kms drivers. That is
> > kinda only a hack for ums/dri1 drivers.
> 
> Are you sure about that - isn't it needed so that the fbdev mode gets
> restored when the last DRM user exits, so that the VT consoles becomes
> functional again?
> 
> I ended up needing a call to drm_fb_helper_restore_fbdev_mode_unlocked()
> in Armada's ->lastclose to ensure that VT consoles worked after Xorg was
> shutdown.

I meant not call it on driver unload. When closing the last drm fd we
indeed need it to restore the fbdev vt. That use-case definitely needs to
stay for kms drivers.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch