From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941191AbcIYXu0 (ORCPT ); Sun, 25 Sep 2016 19:50:26 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:53615 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935036AbcIYXuY (ORCPT ); Sun, 25 Sep 2016 19:50:24 -0400 Date: Sun, 25 Sep 2016 16:50:23 -0700 From: Christoph Hellwig To: Ondrej Zary Cc: Christoph Hellwig , Finn Thain , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c Message-ID: <20160925235023.GC7312@infradead.org> References: <1474743545-4731-1-git-send-email-linux@rainbow-software.org> <1474743545-4731-4-git-send-email-linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474743545-4731-4-git-send-email-linux@rainbow-software.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int generic_NCR5380_isa_match(struct device *pdev, unsigned int ndev) > +{ > + struct Scsi_Host *sh = NULL; > + > + sh = generic_NCR5380_hw_init(&driver_template, pdev, base[ndev], > + irq[ndev], card[ndev]); > + if (!sh && base[ndev]) > + printk(KERN_WARNING "Card not found at address 0x%03x\n", > + base[ndev]); > + if (!sh) > + return 0; > > + dev_set_drvdata(pdev, sh); Any reason not to move the dev_set_drvdata into generic_NCR5380_hw_init? That would also allow to properly propagate the error down to the caller, which would be useful for the PNP case. Otherwise this look great to me.