From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034889AbcIZDxc (ORCPT ); Sun, 25 Sep 2016 23:53:32 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34940 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941326AbcIZDx3 (ORCPT ); Sun, 25 Sep 2016 23:53:29 -0400 Date: Mon, 26 Sep 2016 09:23:25 +0530 From: Viresh Kumar To: Colin King Cc: trivial@kernel.org, "Rafael J . Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: kirkwood: add missing \n to end of dev_err messages Message-ID: <20160926035325.GE17336@vireshk-i7> References: <20160925213543.12267-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160925213543.12267-1-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25-09-16, 14:35, Colin King wrote: > From: Colin Ian King > > Trival fix, dev_err messages are missing a \n, so add it. > > Signed-off-by: Colin Ian King > --- > drivers/cpufreq/kirkwood-cpufreq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpufreq/kirkwood-cpufreq.c b/drivers/cpufreq/kirkwood-cpufreq.c > index be42f10..1b9bcd7 100644 > --- a/drivers/cpufreq/kirkwood-cpufreq.c > +++ b/drivers/cpufreq/kirkwood-cpufreq.c > @@ -123,7 +123,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) > > priv.cpu_clk = of_clk_get_by_name(np, "cpu_clk"); > if (IS_ERR(priv.cpu_clk)) { > - dev_err(priv.dev, "Unable to get cpuclk"); > + dev_err(priv.dev, "Unable to get cpuclk\n"); > return PTR_ERR(priv.cpu_clk); > } > > @@ -132,7 +132,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) > > priv.ddr_clk = of_clk_get_by_name(np, "ddrclk"); > if (IS_ERR(priv.ddr_clk)) { > - dev_err(priv.dev, "Unable to get ddrclk"); > + dev_err(priv.dev, "Unable to get ddrclk\n"); > err = PTR_ERR(priv.ddr_clk); > goto out_cpu; > } > @@ -142,7 +142,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) > > priv.powersave_clk = of_clk_get_by_name(np, "powersave"); > if (IS_ERR(priv.powersave_clk)) { > - dev_err(priv.dev, "Unable to get powersave"); > + dev_err(priv.dev, "Unable to get powersave\n"); > err = PTR_ERR(priv.powersave_clk); > goto out_ddr; > } > @@ -155,7 +155,7 @@ static int kirkwood_cpufreq_probe(struct platform_device *pdev) > if (!err) > return 0; > > - dev_err(priv.dev, "Failed to register cpufreq driver"); > + dev_err(priv.dev, "Failed to register cpufreq driver\n"); > > clk_disable_unprepare(priv.powersave_clk); > out_ddr: Acked-by: Viresh Kumar -- viresh