From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756774AbcIZIS4 (ORCPT ); Mon, 26 Sep 2016 04:18:56 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:41484 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754493AbcIZISx (ORCPT ); Mon, 26 Sep 2016 04:18:53 -0400 Date: Mon, 26 Sep 2016 10:18:41 +0200 From: Sascha Hauer To: Fabien Lahoudere Cc: Peter.Chen@nxp.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 2/2] usb: chipidea: imx: Add binding to disable USB 60Mhz clock Message-ID: <20160926081841.7jmvdto2ht23rdw6@pengutronix.de> References: <1474448827-8354-1-git-send-email-fabien.lahoudere@collabora.co.uk> <1474448827-8354-3-git-send-email-fabien.lahoudere@collabora.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474448827-8354-3-git-send-email-fabien.lahoudere@collabora.co.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:11:09 up 123 days, 18:35, 40 users, load average: 0.08, 0.17, 0.28 User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2016 at 11:07:07AM +0200, Fabien Lahoudere wrote: > This binding allow to disable the internal 60Mhz clock for USB host2 or > host3. > > Signed-off-by: Fabien Lahoudere > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 1 + > drivers/usb/chipidea/ci_hdrc_imx.c | 2 ++ > drivers/usb/chipidea/ci_hdrc_imx.h | 1 + > drivers/usb/chipidea/usbmisc_imx.c | 13 +++++++++++++ > 4 files changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > index 0e03344..f83da66 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt > @@ -84,6 +84,7 @@ i.mx specific properties > - over-current-active-high: over current signal polarity is high active, > typically over current signal polarity is low active. > - external-vbus-divider: enables off-chip resistor divider for Vbus > +- disable-int60ck: disable internal 60MHz clock for usb host2 or host3 on imx53 Why do we need a binding for this? I would assume the driver should know whether this clock is in use or not. If it doesn't that's a problem we should solve. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |