From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965999AbcIZIzx (ORCPT <rfc822;w@1wt.eu>);
        Mon, 26 Sep 2016 04:55:53 -0400
Received: from merlin.infradead.org ([205.233.59.134]:34442 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965905AbcIZIzw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Sep 2016 04:55:52 -0400
Date: Mon, 26 Sep 2016 10:55:47 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Ingo Molnar <mingo@redhat.com>, Oleg Nesterov <oleg@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched: Change READ_ONCE(jiffies) into jiffies
Message-ID: <20160926085547.GJ5012@twins.programming.kicks-ass.net>
References: <f62d0ed3-9fc7-4b3d-cb57-0172e7bf6d53@sandisk.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f62d0ed3-9fc7-4b3d-cb57-0172e7bf6d53@sandisk.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Sep 25, 2016 at 07:08:45PM -0700, Bart Van Assche wrote:
> A quote from Documentation/memory_barriers.txt:
> 
> For example, because 'jiffies' is marked volatile, it is never
> necessary to say READ_ONCE(jiffies).  The reason for this is
> that READ_ONCE() and WRITE_ONCE() are implemented as volatile
> casts, which has no effect when its argument is already marked
> volatile.
> 
> Hence change all 'READ_ONCE(jiffies)' occurrences into 'jiffies'.

So I'm not a huge fan of this patch. Yes its technically pointless, but
it does convey intent. See the READ_ONCE() as a comment if you will.