From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423604AbcIZQ5l (ORCPT ); Mon, 26 Sep 2016 12:57:41 -0400 Received: from smtprelay0224.hostedemail.com ([216.40.44.224]:41303 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934775AbcIZQ5j (ORCPT ); Mon, 26 Sep 2016 12:57:39 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1183:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2911:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3870:4425:5007:6261:7875:10004:10400:10848:10967:11026:11232:11658:11914:12296:12438:12740:12760:13069:13160:13229:13311:13357:13439:14181:14659:14721:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bears64_8475b1cd295b X-Filterd-Recvd-Size: 1574 Date: Mon, 26 Sep 2016 12:57:26 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: mingo@kernel.org, tglx@linutronix.de, juri.lelli@arm.com, xlpang@redhat.com, bigeasy@linutronix.de, linux-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, jdesfossez@efficios.com, bristot@redhat.com Subject: Re: [PATCH -v2 6/9] sched/rtmutex: Refactor rt_mutex_setprio() Message-ID: <20160926125726.60352757@grimm.local.home> In-Reply-To: <20160926124128.202452416@infradead.org> References: <20160926123213.851818224@infradead.org> <20160926124128.202452416@infradead.org> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 26 Sep 2016 14:32:19 +0200 Peter Zijlstra wrote: > @@ -3586,9 +3625,7 @@ void rt_mutex_setprio(struct task_struct > goto out_unlock; > } > > - rt_mutex_update_top_task(p); > - > - trace_sched_pi_setprio(p, prio); > + trace_sched_pi_setprio(p, prio); /* broken */ Not a very comforting comment to see during a review ;-) I'll hold off giving a full review of this patch while in the airport. My mind needs a bit more "quiet" to do this one. -- Steve > oldprio = p->prio; > > if (oldprio == prio)