From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424257AbcIZRNc (ORCPT ); Mon, 26 Sep 2016 13:13:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:56080 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422896AbcIZRNb (ORCPT ); Mon, 26 Sep 2016 13:13:31 -0400 Date: Mon, 26 Sep 2016 19:11:21 +0200 From: David Sterba To: Arnd Bergmann Cc: Chris Mason , Josef Bacik , David Sterba , Jeff Mahoney , Qu Wenruo , Filipe Manana , Omar Sandoval , Anand Jain , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: fix btrfs_no_printk stub helper Message-ID: <20160926171121.GE16983@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Arnd Bergmann , Chris Mason , Josef Bacik , David Sterba , Jeff Mahoney , Qu Wenruo , Filipe Manana , Omar Sandoval , Anand Jain , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160923160532.3619432-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160923160532.3619432-1-arnd@arndb.de> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2016 at 06:05:21PM +0200, Arnd Bergmann wrote: > The addition of btrfs_no_printk() caused a build failure when > CONFIG_PRINTK is disabled: > > fs/btrfs/send.c: In function 'send_rename': > fs/btrfs/ctree.h:3367:2: error: implicit declaration of function 'btrfs_no_printk' [-Werror=implicit-function-declaration] > > This moves the helper outside of that #ifdef so it is always > defined, and changes the existing #ifdef to refer to that > helper as well for consistency. > > Fixes: 47c57058ff2c ("btrfs: btrfs_debug should consume fs_info when DEBUG is not defined") > Signed-off-by: Arnd Bergmann Reviewed-by: David Sterba