From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965676AbcIZLY2 (ORCPT ); Mon, 26 Sep 2016 07:24:28 -0400 Received: from ozlabs.org ([103.22.144.67]:46079 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750754AbcIZLY1 (ORCPT ); Mon, 26 Sep 2016 07:24:27 -0400 Date: Mon, 26 Sep 2016 21:24:22 +1000 From: Stephen Rothwell To: Linus Torvalds Cc: Dave Chinner , Linux Kernel Mailing List , Al Viro Subject: Re: [PATCH] [4.8-rc7, regression] fault_in_multipages_readable() throws set-but-unused error Message-ID: <20160926212422.0bf5a25a@canb.auug.org.au> In-Reply-To: References: <1474847853-9668-1-git-send-email-david@fromorbit.com> <20160926022559.GB27872@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all, On Sun, 25 Sep 2016 20:06:19 -0700 Linus Torvalds wrote: > > exactly like you did. It's just that with 12 characters in the hex > format, people will still be able to cut-and-paste the hash into git > to get the full commit details even a year from now. With just 7 hex > digits, you may well end up in the situation where you do > > git show e23d415 > > and git says > > error: short SHA1 e23d415 is ambiguous. > fatal: ambiguous argument 'e23d415': unknown revision or path not > in the working tree. > > (it's not ambiguous today, but in a year or two it quite possibly will be). I have already had over the years a few instances of 7 digit commit hashes that are unique in Linus' tree but not in mine (which is a bit of a pain if you are trying to look for context). -- Cheers, Stephen Rothwell