From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751540AbcIZWWW (ORCPT ); Mon, 26 Sep 2016 18:22:22 -0400 Received: from ex13-edg-ou-001.vmware.com ([208.91.0.189]:2430 "EHLO EX13-EDG-OU-001.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758588AbcIZWVs (ORCPT ); Mon, 26 Sep 2016 18:21:48 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=syeh@vmware.com; Date: Mon, 26 Sep 2016 15:20:29 -0700 From: Sinclair Yeh To: SF Markus Elfring CC: , , David Airlie , Thomas Hellstrom , LKML , , Julia Lawall Subject: Re: [PATCH 3/3] drm/vmwgfx: Adjust checks for null pointers in 13 functions Message-ID: <20160926222028.GA9904@syeh-m01-3.local> References: <8de6f7c3-5614-b210-7b2f-66c1aed4279b@users.sourceforge.net> <92437e11-dd21-7517-3ddd-431a9703f4ad@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <92437e11-dd21-7517-3ddd-431a9703f4ad@users.sourceforge.net> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [206.169.187.210] X-ClientProxiedBy: BY2PR11CA0015.namprd11.prod.outlook.com (10.163.150.25) To CY4PR05MB3237.namprd05.prod.outlook.com (10.172.156.9) X-MS-Office365-Filtering-Correlation-Id: d472528b-e8a9-4361-3ab1-08d3e65b5bfe X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3237;2:xrpEWnqChZMnHlkl/CHq9DVkQcfK/agLHiXXBpxL7B1EHGVjXqgQYal6h8oxZhzQx587oJT5X23iZAConW7h8Gj93d16AeNxGEZ+LVRpYiFUgXiKGfW/6tlXG3UHFkPIrhWn5JNVJxMdfiGeV2S4Qaq+rgaxzOZkM9GUugNuKz/eGhuBwEJl5qVKwoOqWClMQZmD4GVxFpP+/ubO+7p3Jw==;3:Vl0QGzT3R9GNRkcStczphZOrQbiH0/nHI4hlMNL/RkCoqfj9RANLa2x1YltDfeciyKVdGs0M1ozMG7VWln7WpqIhuAtXDZPEyUVF2PT+XYt8pEin+XDiX9dq5PCQviBW9XpRJ8J0LzH76jt7mJjIPQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY4PR05MB3237; X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3237;25:UHUdqf4/H3ydUH9H5029Lnq6TkIgzY1VBYkkU3BVfBjrispGEFRlXiquc3GwaRAbr8t/zU07dHwzfLtltnTUubT5f5k6z9qn6bbUgc4BUlacFWgVS/Je9YBcDiD4C3KOHm5XKzDY+XuVB9N5fBz+hG51M4zQHK8WfxIciQpdpx37WGgPj7q+UwgpLEDxgDiIY/t11zaEMdJgMtlxEHZ7jS3ZkJX26yJTXdl3MWurjIcKPxQB8DwsJl5txDANiq0vn11afg6uhNccnkdR3185CkDqsM3kv1tnnt2waQja2Ng+sC9KF8JhTz77VPtDw6dJ6snLUqQ+GtP1wS+Sbw7EXz9cEAJkudLPf/z4dfWvcAcPhz0GC+qbwhKhp6v33orNtVuARsQSRJ7omMRoXJbxZGW65GeGlhVtvik+7mfT4XgEFKGFcDBaTVTezcCSB/znt0pmGWjk15YsgX/pxGdrt284670d4qCB3kjDooYpIMKBb0lNK4zlGIYn4DLlce97veareknTdqU1oCgSPuZuHPer9RMjiVZENz1trbnBBloVuco59Vkk6xC3ruHp4BO1ZWcH9sIxhpoPM6DeCTkUxvbV5UcAebMHj6QUsga7U1f8Vo/eBUDhFz9USCNd98ofr6KLcKpj3kGb57gvYForaFB9qTD6ILs2BUUdjxZx5zLjAqwoZzdeHFaL+QWpL7p1/Y7stgEaajDYukdnDC2LDMwwvFLGjLRbwcWuHLQz+/ubpKOV6lxCcrPLFu0Cc6is X-LD-Processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3237;31:E7Z1dBdySfp5+0KJISf0nXqxCGi/d5P90ch/SlT1fQqxyzhhhj1Gtsz5S/NJIXK0cnsl6x0IDFYB79OFP3lmvXWo1lxpsKwnP7Ax531ccAN6lhpQ05CwV+WVzzVE6BwOf03cxXXbCZFdep8nuphLjBCipnTFxv8oc+1Dii89CliUFRd5rHDleAk7I6yuInWw3iP6gszB7fDntkTK54tK7uzQZa5bVUI6D4yJfZPJRdlXAEBf6z5HLMiiE/gGmXx/;20:NPdn8GNG4HKo/Xe7KOGt163XayzdsdTOWr80dKAaFBDzSXixxem0dj4yrx4wjoj5xyEMDxdOu7vYk+krfqLWB6Eq/KK+E3FTK4M2Mvn5IcYppf4xXrwpU6TyXJCVm2sFKvtZYcnygge51IdVGlH1crX7Du72VdOfxkc6x4766bpK+z/TaW43nbJvgYwCwp6ybxS45JlAEiumKQBt3045WPRDWquDOEGUPLksudoAxjDE6w6HMOtofWLXrqnQVPM0RoNp56hyndGX+owbZwuyfpFrAPMq4wIujeoMJtMNvC0WrUs4qJfT5e2oI/5t32htl7HESdfJB1N1nRStBhhASpQX0mQvUJb0D6IKRxtratF7pP8bZBdU7bbg0fvfOcmyM9HzO8sF6OcC9axo0B8GtSviSq/KZpNVMkS9fdSLxF9jPjuvIqC/AVPnGc6FC32NxRpmvbqOqw0MS36vJMlNHmjUw/2GmuagCdTwBTwRMe7CdWGx0i7o80DXzYlHfSD/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150)(42262312472803); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:CY4PR05MB3237;BCL:0;PCL:0;RULEID:;SRVR:CY4PR05MB3237; X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3237;4:4A6Uq7ihEDSBoDEypa+vsBAJvQb12WQqgzmAJhBMYPLpl9FmLUepxEoPcAqR8o73uMDxkiVx+t+tfe37j+mVL7nx6OAmi10jnZ2SvyMachPKwqcyG4HkVHLYlHbt2wvdvWiPf6NI5Xw4CRX0dk4HCe3MToTGfED6eK1ua+vluWmDZkdKXl0eQJuyVaZNVdr48yJ1nmOEUOqEaZxDDhzUQnNgNH3fniMG1Dilu6qAwmPehXgsbCaKSwcM5oXPyganXuJtLIB956e15jpam2DTElynHvUd7le/3D/n2O37iWvFgNsJnzgJd0CmmDHowxPW5JQ8wG4T9DeYh+XqrwXUbDocUkH/aR/blfZtu5dFtPjCQSF3c5uPKYKiNq9LcvLgSuBHyFByYOtm/OlWm7PUz+qTc/D2wKDnBPAUcS+rRIKxcarpobEB5Gkocim3U1el4K8oqZmaAYp+2MOmFCCzn7Q8hcPLKMyKrc+oN6KFmBY= X-Forefront-PRVS: 00770C4423 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(24454002)(47776003)(66066001)(6116002)(586003)(3846002)(4001350100001)(50986999)(189998001)(97736004)(2906002)(83506001)(76176999)(23676002)(1076002)(101416001)(54356999)(77096005)(92566002)(2870700001)(4326007)(68736007)(33656002)(106356001)(105586002)(9686002)(110136003)(2950100002)(42186005)(5660300001)(8676002)(50466002)(6916009)(7736002)(81156014)(81166006)(86362001)(305945005)(7846002)(98436002)(19580395003)(19580405001)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR05MB3237;H:syeh-m01-3.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjA1TUIzMjM3OzIzOkNwYlQ2aWxqZGxteFdGa1J5aWZNQjA1QVE5?= =?utf-8?B?Y1NWa20xRFovWWFScWtiT09uSEp3MHZkNjVtRFAwalU2WUh6ZG82cmFxT28x?= =?utf-8?B?UjRhNEQ0NHIrYy9UbFZJRW11YmxDVGhyODk1czJqb1dPT1l4NGVnRUY4SDgx?= =?utf-8?B?TVlrRDh4QU9CT2l5RGxWS1VCT3hxYW9uR0JHK2Y3Yk12b3FQWFN6TGo3TzU1?= =?utf-8?B?OEZQZ0hoWi9UbnZvV0d1a3pWN1MycUc3dUs0SHpIZEY0UE4rOHJMR0FoQjdt?= =?utf-8?B?L1lIMkR4bmdiOTFwSVpCTit5UHZrVGZHTjNJdEp3dnVVRG9nRURodVJmTXd0?= =?utf-8?B?TzR0enpFNVpLZW01Q1RZU1FPcGVPdmRVTGk1aDI5a3RiSW5TaVhHVGxVNnRZ?= =?utf-8?B?WUY1K2t4eDYxTGtsOHY2WFRKMnJDaGNZT3drRE5TTU02NWU4ZnFTdlIvN3Rp?= =?utf-8?B?S0pwT1VCdXlkYldvUTA3aWlSblpoMFZrbWVSNnRrNVd5cHZBK2FyRThnOE1U?= =?utf-8?B?eUFNeVo2U0xyVHBZeTVjQ3ZGbnd5cG8vMndVN3ZJZE1FLzluRTF2QVNEd1Vk?= =?utf-8?B?WFh0M1RJaDBtS1NmZWlHdEp0T01ZdFVpeTEyZ2Q3OWdib1hpc0poMkMrZ1Ez?= =?utf-8?B?TW5obnhSd3NGTUl6cCtMU1dVTHdibTVBRmdNT1h0K2dzYXp3Q3VqTFl4YVFO?= =?utf-8?B?VElTL3JwZmRjdUZMdEpTUnA1YVU5dDBNblZBZmgvU1Q4Ty9kWFpwMDVFeFZZ?= =?utf-8?B?SElOZXdmRXZvMTY5TjBlWnNSRzM3aHRVRmtRZisxUkprVTF2K3FPZy9RWDNa?= =?utf-8?B?N2JEcktla1hEejdzNVF1WENWOGJRT1I4dS80MTF4eEI0SzJPY3AyeTZtUzg4?= =?utf-8?B?RkxmZStQZFVDbDNlODlGSENQQnUyVURBMFNlUjg0Vi9BdmVhajRLQTJGRmVx?= =?utf-8?B?TXpwZW1LNE9VZXFsejN6bHh4VzZrWUhScE1iTVBBQlZ0YjZmcFlIN3I4VWlQ?= =?utf-8?B?cmZuQU5YN3VUWXhuZ2tnSVB6Wmc4Y01wZ01ySmZ3R0VKVUk2MVJ3OHdnZFBy?= =?utf-8?B?d0tYaWJFbDVJMVFhZlpORTUvMmZJQVliUWdSc0Z6Vi9QWUxBempYRGZFN3JQ?= =?utf-8?B?b3lENTRXMklaT3UxYVVjZWlLcUtBWURIK0R4dThjZE01MG93OW5jWWpxdDFC?= =?utf-8?B?eVBiVTV3cC9sMVY1MDZyd0txVUsrdkJGNi9GeWxodUJzTktoNzFYR1ZSZEF5?= =?utf-8?B?NjNsbkdkbnFoa3RoTUZOZUlFS2tMM3BRZWF2WHNFd3VnN2kra01Pa0JzMm1j?= =?utf-8?B?VEJhaUNTMTRjbSsrNlpPOFArZHRDMGozWGI1cURzZ1NBVWxoRVpoeEtMd2tZ?= =?utf-8?B?ZDM3bVovQjFaYXVBQXM4d3hkUWIvaFhNRlpYVFlIY0FXTkN3SkRIc2V1NkRW?= =?utf-8?B?RzVoSWJaR25VRFY1LzVTN2NxaGsyeTZIYjRTS0p1NE9BUE52TGV0bFFEYzBH?= =?utf-8?B?NS9pMzYrY3h1VTM0QXZSUXVmNjdMbEhCYkNOTnRWWVBPc0pQRUxmcDdhREQx?= =?utf-8?B?YjlOOWkvY3czSUF0VVlEUk81V052cEE9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3237;6:q2VeGd/YTTk9lFePVB3DnWiT3sm2tYbLNvqSJ0ySdi2Eck3Xjvg3E1Zjcun7SgI6CfSy0C8288OyrmV/4IgzxwL1sIXOteMWYnQCwYPEgEqKR37yuuyflX66PV0wLqEVw3gE0wlGa4PQY/xfLk3oP2ukvk/U4BjT7DM04dHR7N6O4GhPxRdSmA2l4kJG6qhMixgoXHXoHuAwulCThx9R7qocKPYdjqNG+sd5Mn7T9+1vJ6eHe6y+bYFqIcQARAZnU7pQsm7OfP/cO2LDOcQT5djBQrAgX8wnDhhuzW/qI0V/NrCc9D2hlqMDmGAs/F+V;5:SEAhYY98AQG5VeTbDUtBrq59ZB+asQxlWGrxHxePyeVKXTw0qlWDNLGc4D1aW87Lpx9ZuLcnecugpS3009qJalpCD/bilFRWdk3q7LF0rMa02DiPnIIMbGRtDAxYFxdyKtByggY63mzV6yPDNkhLqZHJcN5L9T3khfA5TzcwbRA=;24:nQdD/Dv5zLzFWw9uDoSuPYFpwbnUxlgi+Y7qEYQKkrZRszrOFzXM/2MSqGh/pvPIdekmJP9ANvKPd4T50xw80P5Q/3WxaJ6r8G3Bml41FzU=;7:WSBSnay1o6ue8kJWV67iFjwdE1qkjD+2PyK5F4a8UhTeMPgUnTbgUfKn5ITl3RbSGm/E0xuKCJ1JSnJk4PmkptbsOfabCB6Zq0OEVjRgNDdb2T6BI6Ty+Dr1NLfk06S+QTQ9X8qOQ0rd0gv0lf7b2xyBjeVA64pS+M9dRqnSpJcXL+XlnxQQVNDBo4XdSaNOCsNC8NTPTFDlNtuJF2/vIgxhLBB4Ta9q0SoCpWuIYmZcur/2oaE5CYyTc4e2ySQ9y/+4VREE2v+tVL+cI9KC1Q3evNRkVe91MwsskuSmTxICFE4Loto4H9w7pkPImKu5+wD+uoUzjPj4sIOLNvConA== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3237;20:vOtW+VctHh6dreK9KbgH2JY7Kp4ehccvRDtNE8aCjA9gTOEzqOoZ0848mQ6+RgHuvzVZLSjzhxNtwkZFzss8t8tUWfm2kFoN9QqCUos5uxtojGFWVHfaVXWKUQxQdGv9G6RB7g8ha4KcuAEKSFh8Lx7+FlNjA2RXBTFkLLxvmik= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2016 22:20:44.5028 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3237 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series looks good to me: Reviewed-by: Sinclair Yeh Thanks! On Fri, Sep 23, 2016 at 06:39:04PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 23 Sep 2016 17:53:49 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script "checkpatch.pl" can point information out like the following. > > Comparison to NULL could be written !… > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 31 +++++++++++++++---------------- > 1 file changed, 15 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c > index 15504c6..b445ce9 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_surface.c > @@ -324,7 +324,7 @@ static void vmw_hw_surface_destroy(struct vmw_resource *res) > if (res->id != -1) { > > cmd = vmw_fifo_reserve(dev_priv, vmw_surface_destroy_size()); > - if (unlikely(cmd == NULL)) { > + if (unlikely(!cmd)) { > DRM_ERROR("Failed reserving FIFO space for surface " > "destruction.\n"); > return; > @@ -397,7 +397,7 @@ static int vmw_legacy_srf_create(struct vmw_resource *res) > > submit_size = vmw_surface_define_size(srf); > cmd = vmw_fifo_reserve(dev_priv, submit_size); > - if (unlikely(cmd == NULL)) { > + if (unlikely(!cmd)) { > DRM_ERROR("Failed reserving FIFO space for surface " > "creation.\n"); > ret = -ENOMEM; > @@ -446,11 +446,10 @@ static int vmw_legacy_srf_dma(struct vmw_resource *res, > uint8_t *cmd; > struct vmw_private *dev_priv = res->dev_priv; > > - BUG_ON(val_buf->bo == NULL); > - > + BUG_ON(!val_buf->bo); > submit_size = vmw_surface_dma_size(srf); > cmd = vmw_fifo_reserve(dev_priv, submit_size); > - if (unlikely(cmd == NULL)) { > + if (unlikely(!cmd)) { > DRM_ERROR("Failed reserving FIFO space for surface " > "DMA.\n"); > return -ENOMEM; > @@ -538,7 +537,7 @@ static int vmw_legacy_srf_destroy(struct vmw_resource *res) > > submit_size = vmw_surface_destroy_size(); > cmd = vmw_fifo_reserve(dev_priv, submit_size); > - if (unlikely(cmd == NULL)) { > + if (unlikely(!cmd)) { > DRM_ERROR("Failed reserving FIFO space for surface " > "eviction.\n"); > return -ENOMEM; > @@ -578,7 +577,7 @@ static int vmw_surface_init(struct vmw_private *dev_priv, > int ret; > struct vmw_resource *res = &srf->res; > > - BUG_ON(res_free == NULL); > + BUG_ON(!res_free); > if (!dev_priv->has_mob) > vmw_fifo_resource_inc(dev_priv); > ret = vmw_resource_init(dev_priv, res, true, res_free, > @@ -747,7 +746,7 @@ int vmw_surface_define_ioctl(struct drm_device *dev, void *data, > } > > user_srf = kzalloc(sizeof(*user_srf), GFP_KERNEL); > - if (unlikely(user_srf == NULL)) { > + if (unlikely(!user_srf)) { > ret = -ENOMEM; > goto out_no_user_srf; > } > @@ -772,7 +771,7 @@ int vmw_surface_define_ioctl(struct drm_device *dev, void *data, > srf->offsets = kmalloc_array(srf->num_sizes, > sizeof(*srf->offsets), > GFP_KERNEL); > - if (unlikely(srf->offsets == NULL)) { > + if (unlikely(!srf->offsets)) { > ret = -ENOMEM; > goto out_no_offsets; > } > @@ -914,7 +913,7 @@ vmw_surface_handle_reference(struct vmw_private *dev_priv, > > ret = -EINVAL; > base = ttm_base_object_lookup_for_ref(dev_priv->tdev, handle); > - if (unlikely(base == NULL)) { > + if (unlikely(!base)) { > DRM_ERROR("Could not find surface to reference.\n"); > goto out_no_lookup; > } > @@ -1060,7 +1059,7 @@ static int vmw_gb_surface_create(struct vmw_resource *res) > > cmd = vmw_fifo_reserve(dev_priv, submit_len); > cmd2 = (typeof(cmd2))cmd; > - if (unlikely(cmd == NULL)) { > + if (unlikely(!cmd)) { > DRM_ERROR("Failed reserving FIFO space for surface " > "creation.\n"); > ret = -ENOMEM; > @@ -1126,7 +1125,7 @@ static int vmw_gb_surface_bind(struct vmw_resource *res, > submit_size = sizeof(*cmd1) + (res->backup_dirty ? sizeof(*cmd2) : 0); > > cmd1 = vmw_fifo_reserve(dev_priv, submit_size); > - if (unlikely(cmd1 == NULL)) { > + if (unlikely(!cmd1)) { > DRM_ERROR("Failed reserving FIFO space for surface " > "binding.\n"); > return -ENOMEM; > @@ -1176,7 +1175,7 @@ static int vmw_gb_surface_unbind(struct vmw_resource *res, > > submit_size = sizeof(*cmd3) + (readback ? sizeof(*cmd1) : sizeof(*cmd2)); > cmd = vmw_fifo_reserve(dev_priv, submit_size); > - if (unlikely(cmd == NULL)) { > + if (unlikely(!cmd)) { > DRM_ERROR("Failed reserving FIFO space for surface " > "unbinding.\n"); > return -ENOMEM; > @@ -1235,7 +1234,7 @@ static int vmw_gb_surface_destroy(struct vmw_resource *res) > vmw_binding_res_list_scrub(&res->binding_head); > > cmd = vmw_fifo_reserve(dev_priv, sizeof(*cmd)); > - if (unlikely(cmd == NULL)) { > + if (unlikely(!cmd)) { > DRM_ERROR("Failed reserving FIFO space for surface " > "destruction.\n"); > mutex_unlock(&dev_priv->binding_mutex); > @@ -1401,7 +1400,7 @@ int vmw_gb_surface_reference_ioctl(struct drm_device *dev, void *data, > > user_srf = container_of(base, struct vmw_user_surface, prime.base); > srf = &user_srf->srf; > - if (srf->res.backup == NULL) { > + if (!srf->res.backup) { > DRM_ERROR("Shared GB surface is missing a backup buffer.\n"); > goto out_bad_resource; > } > @@ -1515,7 +1514,7 @@ int vmw_surface_gb_priv_define(struct drm_device *dev, > } > > user_srf = kzalloc(sizeof(*user_srf), GFP_KERNEL); > - if (unlikely(user_srf == NULL)) { > + if (unlikely(!user_srf)) { > ret = -ENOMEM; > goto out_no_user_srf; > } > -- > 2.10.0 >