mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: parameswaran.r7@gmail.com
Cc: kleptog@svana.org, jchapman@katalix.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, nprachan@brocade.com,
	rshearma@brocade.com, dfawcus@brocade.com,
	stephen@networkplumber.org, acme@redhat.com,
	lboccass@brocade.com
Subject: Re: [PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2
Date: Tue, 27 Sep 2016 03:31:53 -0400 (EDT)	[thread overview]
Message-ID: <20160927.033153.1066118008027608891.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1609221341500.6975@duvvury30.eng.vyatta.net>

From: "R. Parameswaran" <parameswaran.r7@gmail.com>
Date: Thu, 22 Sep 2016 13:52:43 -0700 (PDT)

> From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001
> From: "R. Parameswaran" <rparames@brocade.com>
> Date: Thu, 22 Sep 2016 13:19:25 -0700
> Subject: [PATCH] L2TP:Adjust intf MTU,factor underlay L3,overlay L2
> 
> Take into account all of the tunnel encapsulation headers when setting
> up the MTU on the L2TP logical interface device. Otherwise, packets
> created by the applications on top of the L2TP layer are larger
> than they ought to be, relative to the underlay MTU, leading to
> needless fragmentation once the outer IP encap is added.
> 
> Specifically, take into account the (outer, underlay) IP header
> imposed on the encapsulated L2TP packet, and the Layer 2 header
> imposed on the inner IP packet prior to L2TP encapsulation.
> 
> Do not assume an Ethernet (non-jumbo) underlay. Use the PMTU mechanism
> and the dst entry in the L2TP tunnel socket to directly pull up
> the underlay MTU (as the baseline number on top of which the
> encapsulation headers are factored in).  Fall back to Ethernet MTU
> if this fails.
> 
> Signed-off-by: R. Parameswaran <rparames@brocade.com>
> 
> Reviewed-by: "N. Prachanda" <nprachan@brocade.com>,
> Reviewed-by: "R. Shearman" <rshearma@brocade.com>,
> Reviewed-by: "D. Fawcus" <dfawcus@brocade.com>

I have to ask, how do other tunnels over UDP such as VXLAN handle
this problem?

  reply	other threads:[~2016-09-27  7:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 20:52 R. Parameswaran
2016-09-27  7:31 ` David Miller [this message]
2016-09-27 19:17   ` R. Parameswaran
2016-09-28  7:48     ` David Miller
2016-09-29  2:36       ` R. Parameswaran
2016-09-29 12:21         ` Jiri Benc
2016-09-29 15:39         ` James Chapman
2016-09-29 15:18 ` James Chapman
2016-09-30  2:39   ` R. Parameswaran
2016-10-01 16:50     ` James Chapman
2016-10-04  3:12       ` R. Parameswaran
2016-10-04  7:53         ` James Chapman
     [not found]           ` <CAGeBGG7AS1JZYHC6T5_H6vY4wfptUtPzO=+kdCcUzJGXA0m6_A@mail.gmail.com>
2016-10-11  7:47             ` James Chapman
2016-10-17  4:05               ` [RFC PATCH v3 1/2] " R. Parameswaran
2016-10-17  5:20               ` [RFC PATCH v3 2/2] " R. Parameswaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160927.033153.1066118008027608891.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=acme@redhat.com \
    --cc=dfawcus@brocade.com \
    --cc=jchapman@katalix.com \
    --cc=kleptog@svana.org \
    --cc=lboccass@brocade.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nprachan@brocade.com \
    --cc=parameswaran.r7@gmail.com \
    --cc=rshearma@brocade.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®