From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754215AbcI0HwP convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Sep 2016 03:52:15 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:44012 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753173AbcI0HwG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Sep 2016 03:52:06 -0400
Date: Tue, 27 Sep 2016 03:52:01 -0400 (EDT)
Message-Id: <20160927.035201.185206386895576436.davem@davemloft.net>
To: mic@digikod.net
Cc: linux-kernel@vger.kernel.org, ast@kernel.org, luto@amacapital.net,
        daniel@iogearbox.net, keescook@chromium.org, sargun@sargun.me,
        tj@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3] bpf: Set register type according to
 is_valid_access()
From: David Miller <davem@davemloft.net>
In-Reply-To: <20160924180150.23620-1-mic@digikod.net>
References: <20160924180150.23620-1-mic@digikod.net>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 27 Sep 2016 00:52:05 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Mickaël Salaün <mic@digikod.net>
Date: Sat, 24 Sep 2016 20:01:50 +0200

> This prevent future potential pointer leaks when an unprivileged eBPF
> program will read a pointer value from its context. Even if
> is_valid_access() returns a pointer type, the eBPF verifier replace it
> with UNKNOWN_VALUE. The register value that contains a kernel address is
> then allowed to leak. Moreover, this fix allows unprivileged eBPF
> programs to use functions with (legitimate) pointer arguments.
> 
> Not an issue currently since reg_type is only set for PTR_TO_PACKET or
> PTR_TO_PACKET_END in XDP and TC programs that can only be loaded as
> privileged. For now, the only unprivileged eBPF program allowed is for
> socket filtering and all the types from its context are UNKNOWN_VALUE.
> However, this fix is important for future unprivileged eBPF programs
> which could use pointers in their context.
> 
> Signed-off-by: Mickaël Salaün <mic@digikod.net>

Applied to net-next, thanks.