From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934325AbcI0MAc (ORCPT ); Tue, 27 Sep 2016 08:00:32 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46404 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934271AbcI0MAS (ORCPT ); Tue, 27 Sep 2016 08:00:18 -0400 Date: Tue, 27 Sep 2016 07:59:56 -0400 (EDT) Message-Id: <20160927.075956.93420092875299733.davem@davemloft.net> To: jhansen@vmware.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, gregkh@linuxfoundation.org, pv-drivers@vmware.com, stefanha@redhat.com Subject: Re: [PATCH] VSOCK: Don't dec ack backlog twice for rejected connections From: David Miller In-Reply-To: <1474959593-15311-1-git-send-email-jhansen@vmware.com> References: <1474959593-15311-1-git-send-email-jhansen@vmware.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 27 Sep 2016 04:59:58 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jorgen Hansen Date: Mon, 26 Sep 2016 23:59:53 -0700 > If a pending socket is marked as rejected, we will decrease the > sk_ack_backlog twice. So don't decrement it for rejected sockets > in vsock_pending_work(). > > Testing of the rejected socket path was done through code > modifications. > > Reported-by: Stefan Hajnoczi > Signed-off-by: Jorgen Hansen > Reviewed-by: Adit Ranadive > Reviewed-by: Aditya Sarwade Applied, thanks.