From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932674AbcI0NqD (ORCPT ); Tue, 27 Sep 2016 09:46:03 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:47496 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753736AbcI0Np4 (ORCPT ); Tue, 27 Sep 2016 09:45:56 -0400 Date: Tue, 27 Sep 2016 09:45:51 -0400 (EDT) Message-Id: <20160927.094551.1178979867316917587.davem@davemloft.net> To: hejianet@gmail.com Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, vyasevich@gmail.com, nhorman@tuxdriver.com, steffen.klassert@secunet.com, herbert@gondor.apana.org.au, marcelo.leitner@gmail.com Subject: Re: [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq_show From: David Miller In-Reply-To: <1474877355-12920-3-git-send-email-hejianet@gmail.com> References: <1474877355-12920-1-git-send-email-hejianet@gmail.com> <1474877355-12920-3-git-send-email-hejianet@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 27 Sep 2016 06:45:55 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jia He Date: Mon, 26 Sep 2016 16:09:10 +0800 > +static int snmp_seq_show_tcp_udp(struct seq_file *seq, void *v) > +{ > + int i; > + unsigned long buff[TCPUDP_MIB_MAX]; > + struct net *net = seq->private; Please always order local variables from longest to shortest line. Please audit your entire patch series for this problem. Thanks.