From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753556AbcI0HkH (ORCPT ); Tue, 27 Sep 2016 03:40:07 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35147 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbcI0HkA (ORCPT ); Tue, 27 Sep 2016 03:40:00 -0400 From: Yannis Damigos To: gregkh@linuxfoundation.org Cc: markus.boehme@mailbox.org, arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Yannis Damigos Subject: [PATCHv4 1/4] staging:android:ion: Fix comparison with NULL Date: Tue, 27 Sep 2016 10:38:23 +0300 Message-Id: <20160927073826.20301-1-giannis.damigos@gmail.com> X-Mailer: git-send-email 2.10.0 In-Reply-To: <20160923121822.GD21575@kroah.com> References: <20160923121822.GD21575@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixes the following comparison with NULL issues: CHECK: Comparison to NULL could be written "compatible[i].name" + for (i = 0; compatible[i].name != NULL; i++) { CHECK: Comparison to NULL could be written "!compatible[i].name" + if (compatible[i].name == NULL) Signed-off-by: Yannis Damigos --- drivers/staging/android/ion/ion_of.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index 826e756..a8050c6 100644 --- a/drivers/staging/android/ion/ion_of.c +++ b/drivers/staging/android/ion/ion_of.c @@ -31,12 +31,12 @@ static int ion_parse_dt_heap_common(struct device_node *heap_node, { int i; - for (i = 0; compatible[i].name != NULL; i++) { + for (i = 0; compatible[i].name; i++) { if (of_device_is_compatible(heap_node, compatible[i].compat)) break; } - if (compatible[i].name == NULL) + if (!compatible[i].name) return -ENODEV; heap->id = compatible[i].heap_id; -- 2.10.0