From: Andrey Utkin <andrey_utkin@fastmail.com>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Andrey Utkin <andrey.utkin@corp.bluecherry.net>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Ismael Luceno <ismael@iodev.co.uk>,
Bluecherry Maintainers <maintainers@bluecherrydvr.com>
Subject: Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)
Date: Tue, 27 Sep 2016 10:40:09 +0300 [thread overview]
Message-ID: <20160927074009.3kcvruynnapj6y3q@zver> (raw)
In-Reply-To: <m337kldi92.fsf@t19.piap.pl>
[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]
On Tue, Sep 27, 2016 at 07:27:53AM +0200, Krzysztof Hałasa wrote:
> Andrey Utkin <andrey_utkin@fastmail.com> writes:
>
> >> Does (only) adding the
> >>
> >> pci_read_config_word(solo_dev->pdev, PCI_STATUS, &val);
> >>
> >> in solo_reg_write() help?
> >
> > Yes.
> > I have posted a patch with this change few days ago, I thought you have
> > noticed it.
>
> Well, I think you haven't sent me a copy. Anyway, it would be great to
> determine where exactly writes need a flush. Adding it everywhere is a
> bit suboptimal, one would think.
Oh, I'm terribly sorry, I really meant to send you a copy.
Actual posting is:
lkml.kernel.org/r/20160922000331.4193-1-andrey.utkin@corp.bluecherry.net
> Can you share some details about the machine you are experiencing the
> problems on? CPU, chipset? I'd try to see if I can recreate the problem.
See solo.txt.gz attached.
> Alternatively, you could investigate yourself - at first you could put
> pci_read_config_word() at the end of subroutines (including return
> statements) using solo_reg_write(). And in that solo_p2m_dma_desc(),
> before wait_for_completion_timeout(). Then eliminate them using some
> sort of binary search to see which ones are required.
Sorry, but I've got no time for this long-lasting debug session right
now, and except for this issue, users enjoy their mainline kernel
driver. So I'd just fix that in mainline kernels as quickly as possible.
Now I'm even considering submitting that to longterm 4.4 branch.
[-- Attachment #2: solo.txt.gz --]
[-- Type: application/octet-stream, Size: 7654 bytes --]
next prev parent reply other threads:[~2016-09-27 7:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 13:04 Andrey Utkin
2016-09-15 13:15 ` Hans Verkuil
2016-09-15 13:19 ` Andrey Utkin
2016-09-15 13:25 ` Hans Verkuil
2016-09-15 13:58 ` One Thousand Gnomes
2016-09-21 13:16 ` Krzysztof Hałasa
2016-09-21 13:45 ` Andrey Utkin
2016-09-22 8:51 ` Krzysztof Hałasa
2016-09-22 15:23 ` Andrey Utkin
2016-09-26 5:38 ` Krzysztof Hałasa
2016-09-26 9:18 ` Andrey Utkin
2016-09-27 5:27 ` Krzysztof Hałasa
2016-09-27 7:40 ` Andrey Utkin [this message]
2016-09-27 11:33 ` Krzysztof Hałasa
2016-09-27 14:22 ` Andrey Utkin
2016-09-28 5:21 ` Krzysztof Hałasa
2016-10-24 19:32 ` Mauro Carvalho Chehab
2016-10-24 20:56 ` Andrey Utkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927074009.3kcvruynnapj6y3q@zver \
--to=andrey_utkin@fastmail.com \
--cc=andrey.utkin@corp.bluecherry.net \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=ismael@iodev.co.uk \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®