From: David Miller <davem@davemloft.net>
To: hejianet@gmail.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
vyasevich@gmail.com, nhorman@tuxdriver.com,
steffen.klassert@secunet.com, herbert@gondor.apana.org.au,
marcelo.leitner@gmail.com
Subject: Re: [PATCH v5 0/7] Reduce cache miss for snmp_fold_field
Date: Wed, 28 Sep 2016 05:08:17 -0400 (EDT) [thread overview]
Message-ID: <20160928.050817.110671274247345232.davem@davemloft.net> (raw)
In-Reply-To: <1475043748-18161-1-git-send-email-hejianet@gmail.com>
From: Jia He <hejianet@gmail.com>
Date: Wed, 28 Sep 2016 14:22:21 +0800
> v5:
> - order local variables from longest to shortest line
I still see many cases where this problem still exists. Please
do not resubmit this patch series until you fix all of them.
Patch #2:
-static int snmp_seq_show(struct seq_file *seq, void *v)
+static int snmp_seq_show_ipstats(struct seq_file *seq, void *v)
{
int i;
+ u64 buff64[IPSTATS_MIB_MAX];
struct net *net = seq->private;
The order should be "net" then "buff64" then "i".
+static int snmp_seq_show_tcp_udp(struct seq_file *seq, void *v)
+{
+ int i;
+ struct net *net = seq->private;
+ unsigned long buff[TCPUDP_MIB_MAX];
The order should be "buff", "net", then "i".
Patch #3:
@@ -192,13 +197,19 @@ static void snmp6_seq_show_item(struct seq_file *seq, void __percpu *pcpumib,
const struct snmp_mib *itemlist)
{
int i;
- unsigned long val;
-
...
+ unsigned long buff[SNMP_MIB_MAX];
The order should be "buff" then "i".
@@ -206,10 +217,13 @@ static void snmp6_seq_show_item64(struct seq_file *seq, void __percpu *mib,
const struct snmp_mib *itemlist, size_t syncpoff)
{
int i;
+ u64 buff64[SNMP_MIB_MAX];
Likewise.
I cannot be any more explicit in my request than this.
next prev parent reply other threads:[~2016-09-28 9:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 6:22 Jia He
2016-09-28 6:22 ` [PATCH v5 1/7] net:snmp: Introduce generic interfaces for snmp_get_cpu_field{,64} Jia He
2016-09-28 6:22 ` [PATCH v5 2/7] proc: Reduce cache miss in snmp_seq_show Jia He
2016-09-28 6:22 ` [PATCH v5 3/7] proc: Reduce cache miss in snmp6_seq_show Jia He
2016-09-28 6:22 ` [PATCH v5 4/7] proc: Reduce cache miss in sctp_snmp_seq_show Jia He
2016-09-28 6:22 ` [PATCH v5 5/7] proc: Reduce cache miss in xfrm_statistics_seq_show Jia He
2016-09-28 6:22 ` [PATCH v5 6/7] ipv6: Remove useless parameter in __snmp6_fill_statsdev Jia He
2016-09-28 6:22 ` [PATCH v5 7/7] net: Suppress the "Comparison to NULL could be written" warnings Jia He
2016-09-28 9:08 ` David Miller [this message]
2016-09-28 13:45 ` [PATCH v5 0/7] Reduce cache miss for snmp_fold_field hejianet
2016-09-28 15:58 ` Local variable ordering (was Re: [PATCH v5 0/7] Reduce cache miss for snmp_fold_field) Edward Cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928.050817.110671274247345232.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hejianet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=steffen.klassert@secunet.com \
--cc=vyasevich@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®