From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754119AbcI1MJ5 (ORCPT ); Wed, 28 Sep 2016 08:09:57 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:33656 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753607AbcI1MJc (ORCPT ); Wed, 28 Sep 2016 08:09:32 -0400 Date: Wed, 28 Sep 2016 08:09:24 -0400 (EDT) Message-Id: <20160928.080924.262829446101549341.davem@davemloft.net> To: jhs@mojatatu.com Cc: gorcunov@gmail.com, eric.dumazet@gmail.com, dsa@cumulusnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, avagin@openvz.org, stephen@networkplumber.org Subject: Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets From: David Miller In-Reply-To: <696ed966-991c-30f7-9a1c-d91a94c9304c@mojatatu.com> References: <484dedaf-4e81-9a5a-ffb8-2c65b373c3a0@mojatatu.com> <20160928112703.GW1876@uranus.lan> <696ed966-991c-30f7-9a1c-d91a94c9304c@mojatatu.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 28 Sep 2016 05:09:29 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:06:51 -0400 > I understood well your point;-> Maybe my response was not clear: > _nobody should be fscking fondling pad fields_ setting them or > otherwise. Especially considering potential future uses of the field, existing users absolutely must zero out the field. Whether this is via a memset() of the entire structure or via an explicit initialization to zero is their choice. So setting 'pad' is in fact valid.