From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932303AbcI1MRB (ORCPT ); Wed, 28 Sep 2016 08:17:01 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:33788 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932179AbcI1MQw (ORCPT ); Wed, 28 Sep 2016 08:16:52 -0400 Date: Wed, 28 Sep 2016 08:16:46 -0400 (EDT) Message-Id: <20160928.081646.1634500099795129398.davem@davemloft.net> To: jhs@mojatatu.com Cc: gorcunov@gmail.com, eric.dumazet@gmail.com, dsa@cumulusnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, avagin@openvz.org, stephen@networkplumber.org Subject: Re: [PATCH v5] net: ip, diag -- Add diag interface for raw sockets From: David Miller In-Reply-To: <60b2e075-e852-f0c2-c188-631f547791d5@mojatatu.com> References: <20160928112703.GW1876@uranus.lan> <20160928.080701.1194277590163223525.davem@davemloft.net> <60b2e075-e852-f0c2-c188-631f547791d5@mojatatu.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 28 Sep 2016 05:16:50 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jamal Hadi Salim Date: Wed, 28 Sep 2016 08:09:28 -0400 > On 16-09-28 08:07 AM, David Miller wrote: > >> Right, it would be legal for an existing user to have code that >> explicitly initializes every member of the structure, including 'pad'. >> So we have to keep that member around, at a minimum, for their sake. >> > > I think we need to start labelling any new pad fields added as > "Not UAPI. Do not fsck fondle this". They must initialize it to zero.