From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933053AbcI1Pa0 (ORCPT ); Wed, 28 Sep 2016 11:30:26 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36578 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932319AbcI1PaV (ORCPT ); Wed, 28 Sep 2016 11:30:21 -0400 Date: Wed, 28 Sep 2016 11:30:18 -0400 (EDT) Message-Id: <20160928.113018.46166819947237523.davem@davemloft.net> To: mike.kravetz@oracle.com Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, nitin.m.gupta@oracle.com Subject: Re: [PATCH v2] sparc64 mm: Fix more TSB sizing issues From: David Miller In-Reply-To: <1472676499-6325-1-git-send-email-mike.kravetz@oracle.com> References: <1472676499-6325-1-git-send-email-mike.kravetz@oracle.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 28 Sep 2016 08:30:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Kravetz Date: Wed, 31 Aug 2016 13:48:19 -0700 > Commit af1b1a9b36b8 ("sparc64 mm: Fix base TSB sizing when hugetlb > pages are used") addressed the difference between hugetlb and THP > pages when computing TSB sizes. The following additional issues > were also discovered while working with the code. > > In order to save memory, THP makes use of a huge zero page. This huge > zero page does not count against a task's RSS, but it does consume TSB > entries. This is similar to hugetlb pages. Therefore, count huge > zero page entries in hugetlb_pte_count. > > Accounting of THP pages is done in the routine set_pmd_at(). > Unfortunately, this does not catch the case where a THP page is split. > To handle this case, decrement the count in pmdp_invalidate(). > pmdp_invalidate is only called when splitting a THP. However, 'sanity > checks' are added in case it is ever called for other purposes. > > A more general issue exists with HPAGE_SIZE accounting. > hugetlb_pte_count tracks the number of HPAGE_SIZE (8M) pages. This > value is used to size the TSB for HPAGE_SIZE pages. However, > each HPAGE_SIZE page consists of two REAL_HPAGE_SIZE (4M) pages. > The TSB contains an entry for each REAL_HPAGE_SIZE page. Therefore, > the number of REAL_HPAGE_SIZE pages should be used to size the huge > page TSB. A new compile time constant REAL_HPAGE_PER_HPAGE is used > to multiply hugetlb_pte_count before sizing the TSB. > > Changes from V1 > - Fixed build issue if hugetlb or THP not configured > > Signed-off-by: Mike Kravetz Applied.