From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754159AbcI1Xwx (ORCPT ); Wed, 28 Sep 2016 19:52:53 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:41159 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752736AbcI1Xwn (ORCPT ); Wed, 28 Sep 2016 19:52:43 -0400 Date: Wed, 28 Sep 2016 16:52:35 -0700 From: Darren Hart To: Julia Lawall Cc: Souvik Kumar Chakravarty , joe@perches.com, kernel-janitors@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/26] intel_telemetry_debugfs: constify local structures Message-ID: <20160928235235.GD7630@f23x64.localdomain> References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-18-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473599168-30561-18-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 11, 2016 at 03:05:59PM +0200, Julia Lawall wrote: Hi Julia, > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken Hrm. telem_apl_debugfs_conf is passed to the TELEM_DEBUGFS_CPU macro as the second argument "data": #define TELEM_DEBUGFS_CPU(model, data) \ { X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data} And the address is taken, and later assigned to the debugfs_conf pointer. The usage still seems OK, but did I misunderstand the conditions? > 3. Not passed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. > > Done using Coccinelle. > Based on a suggestion by Joe Perches . > Signed-off-by: Julia Lawall > > --- > The semantic patch seems too long for a commit log, but is in the cover > letter. > > drivers/platform/x86/intel_telemetry_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c > index ef29f18..d0761f3 100644 > --- a/drivers/platform/x86/intel_telemetry_debugfs.c > +++ b/drivers/platform/x86/intel_telemetry_debugfs.c > @@ -297,7 +297,7 @@ struct telemetry_debugfs_conf { > > static struct telemetry_debugfs_conf *debugfs_conf; > > -static struct telemetry_debugfs_conf telem_apl_debugfs_conf = { > +static const struct telemetry_debugfs_conf telem_apl_debugfs_conf = { > .pss_idle_data = telem_apl_pss_idle_data, > .pcs_idle_blkd_data = telem_apl_pcs_idle_blkd_data, > .pcs_s0ix_blkd_data = telem_apl_pcs_s0ix_blkd_data, > > -- Darren Hart Intel Open Source Technology Center