From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754449AbcI2GQa convert rfc822-to-8bit (ORCPT ); Thu, 29 Sep 2016 02:16:30 -0400 Received: from TYO200.gate.nec.co.jp ([210.143.35.50]:60841 "EHLO tyo200.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753013AbcI2GQW (ORCPT ); Thu, 29 Sep 2016 02:16:22 -0400 From: Naoya Horiguchi To: Gerald Schaefer CC: Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Michal Hocko , "Kirill A . Shutemov" , Vlastimil Babka , Mike Kravetz , "Aneesh Kumar K . V" , Martin Schwidefsky , Heiko Carstens , "Rui Teng" , Dave Hansen Subject: Re: [PATCH v4 0/3] mm/hugetlb: memory offline issues with hugepages Thread-Topic: [PATCH v4 0/3] mm/hugetlb: memory offline issues with hugepages Thread-Index: AQHSGBtkWrYmkonJ+k2SDNc2q1o9yKCPammA Date: Thu, 29 Sep 2016 06:14:36 +0000 Message-ID: <20160929061435.GA3073@hori1.linux.bs1.fc.nec.co.jp> References: <20160926172811.94033-1-gerald.schaefer@de.ibm.com> In-Reply-To: <20160926172811.94033-1-gerald.schaefer@de.ibm.com> Accept-Language: en-US, ja-JP Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.10] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 26, 2016 at 07:28:08PM +0200, Gerald Schaefer wrote: > This addresses several issues with hugepages and memory offline. While > the first patch fixes a panic, and is therefore rather important, the > last patch is just a performance optimization. > > The second patch fixes a theoretical issue with reserved hugepages, > while still leaving some ugly usability issue, see description. > > Changes in v4: > - Add check for free vs. reserved hugepages > - Revalidate checks in dissolve_free_huge_page() after taking the lock > - Split up into 3 patches > > Changes in v3: > - Add Fixes: c8721bbb > - Add Cc: stable > - Elaborate on losing the gigantic page vs. failing memory offline > - Move page_count() check out of dissolve_free_huge_page() > > Changes in v2: > - Update comment in dissolve_free_huge_pages() > - Change locking in dissolve_free_huge_page() > > Gerald Schaefer (3): > mm/hugetlb: fix memory offline with hugepage size > memory block size > mm/hugetlb: check for reserved hugepages during memory offline > mm/hugetlb: improve locking in dissolve_free_huge_pages() > > include/linux/hugetlb.h | 6 +++--- > mm/hugetlb.c | 47 +++++++++++++++++++++++++++++++++++------------ > mm/memory_hotplug.c | 4 +++- > 3 files changed, 41 insertions(+), 16 deletions(-) I'm happy with these patches fixing/improving hugetlb offline code, thank you very much, Gerald and reviewers/testers! For patchset ... Acked-by: Naoya Horiguchi