From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755403AbcI2IyM (ORCPT ); Thu, 29 Sep 2016 04:54:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:53608 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752894AbcI2IyD (ORCPT ); Thu, 29 Sep 2016 04:54:03 -0400 Date: Thu, 29 Sep 2016 10:54:05 +0200 From: Greg KH To: Manish Narani Cc: balbi@kernel.org, k.opasiak@samsung.com, r.baldyga@samsung.com, peter.chen@freescale.com, mnarani@xilinx.com, John.Youn@synopsys.com, eu@felipetonello.com, i.kotrasinsk@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, anuragku@xilinx.com, punnaia@xilinx.com Subject: Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero. Message-ID: <20160929085405.GA8895@kroah.com> References: <1475138804-3335-1-git-send-email-mnarani@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475138804-3335-1-git-send-email-mnarani@xilinx.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2016 at 02:16:44PM +0530, Manish Narani wrote: > This patch adds support to configure bulk maxburst through > module parameter. This parameter can be used to modify bulk > maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT > performance. Eeek, this isn't the 1990's, please don't add new module parameters :) We have much better ways of handling configuration options for a device, why not use them (configfs, sysfs files, etc.)? Ugh, it looks like iso_maxburst is handled this way as well. Felipe, why is this? thanks, greg k-h