From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964853AbcI3F5X (ORCPT ); Fri, 30 Sep 2016 01:57:23 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:36790 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935602AbcI3F5O (ORCPT ); Fri, 30 Sep 2016 01:57:14 -0400 Date: Fri, 30 Sep 2016 01:57:09 -0400 (EDT) Message-Id: <20160930.015709.1828493203935150678.davem@davemloft.net> To: ddecotig@gmail.com Cc: yishaih@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, decot@googlers.com Subject: Re: [PATCH v1] mlx4: remove unused fields From: David Miller In-Reply-To: <1475085604-101493-1-git-send-email-ddecotig@gmail.com> References: <1475085604-101493-1-git-send-email-ddecotig@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 29 Sep 2016 22:57:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Decotigny Date: Wed, 28 Sep 2016 11:00:04 -0700 > From: David Decotigny > > This also can address following UBSAN warnings: > [ 36.640343] ================================================================================ > [ 36.648772] UBSAN: Undefined behaviour in drivers/net/ethernet/mellanox/mlx4/fw.c:857:26 > [ 36.656853] shift exponent 64 is too large for 32-bit type 'int' > [ 36.663348] ================================================================================ > [ 36.671783] ================================================================================ > [ 36.680213] UBSAN: Undefined behaviour in drivers/net/ethernet/mellanox/mlx4/fw.c:861:27 > [ 36.688297] shift exponent 35 is too large for 32-bit type 'int' > [ 36.694702] ================================================================================ > > Tested: > reboot with UBSAN, no warning. > > Signed-off-by: David Decotigny Applied to net-next, thanks.