From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936219AbcI3FyZ (ORCPT ); Fri, 30 Sep 2016 01:54:25 -0400 Received: from imap.thunk.org ([74.207.234.97]:47614 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936161AbcI3FyT (ORCPT ); Fri, 30 Sep 2016 01:54:19 -0400 Date: Fri, 30 Sep 2016 01:53:52 -0400 From: "Theodore Ts'o" To: Richard Weinberger Cc: adilger.kernel@dilger.ca, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, david@sigma-star.at Subject: Re: [PATCH] ext4: Check for encryption feature before fscrypt_process_policy() Message-ID: <20160930055352.qhqvxpwino4yomdo@thunk.org> Mail-Followup-To: Theodore Ts'o , Richard Weinberger , adilger.kernel@dilger.ca, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, david@sigma-star.at References: <1474527054-24207-1-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474527054-24207-1-git-send-email-richard@nod.at> User-Agent: NeoMutt/20160910 (1.7.0) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2016 at 08:50:54AM +0200, Richard Weinberger wrote: > ...otherwise an user can enable encryption for certain files even > when the filesystem is unable to support it. > Such a case would be a filesystem created by mkfs.ext4's default > settings, 1KiB block size. Ext4 supports encyption only when block size > is equal to PAGE_SIZE. > But this constraint is only checked when the encryption feature flag > is set. > > Signed-off-by: Richard Weinberger Thanks, applied. - Ted