From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <thierry.reding@gmail.com>, <jingoohan1@gmail.com>,
<lee.jones@linaro.org>
Cc: <tomi.valkeinen@ti.com>, <linux-pwm@vger.kernel.org>,
<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<p.zabel@pengutronix.de>
Subject: [PATCH 0/2] backlight: pwm_bl: Fix the initial power state selection
Date: Fri, 30 Sep 2016 10:02:57 +0300 [thread overview]
Message-ID: <20160930070259.5710-1-peter.ujfalusi@ti.com> (raw)
Hi,
3698d7e7d221 backlight: pwm_bl: Avoid backlight flicker when probed from DT
added support for avoiding backlight flickering, which in essence was designed
to not enable the baclkight when the driver loads, but let the user of the
backlight to enable it later on.
There are boards (like am437x-gp-evm) where we do not have valid GPIO to enable
the backlight (TPS61081DRC's EN pin is connected to V3_3D) and the regulator
is always on (VBAT in case of the gp-evm). In this board the logic to check the
GPIO state and the regulator is failing and the backlight will be enabled as
soon as the pwm_bl driver is loaded.
By extending the check to look at the PWM state this issue can be avoided and
the backlight will be enabled only when it's user is asking it to be enabled.
Note:
I don't know the history of 3698d7e7d221, but I would have opted to add a DT
bool property (default-off) indicating that the given backlight device must stay
off when the driver is probing, other driver will enable it later.
This way all pwm driver could use the same property (gpio-backlight would need
to be converted) and the backward compatibility would have been retained.
Regards,
Peter
---
Peter Ujfalusi (2):
backlight: pwm_bl: Move the checks for initial power state to a
separate function
backlight: pwm_bl: Check the pwm state for initial backlight power
state
drivers/video/backlight/pwm_bl.c | 59 ++++++++++++++++++++++++++--------------
1 file changed, 39 insertions(+), 20 deletions(-)
--
2.10.0
next reply other threads:[~2016-09-30 7:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 7:02 Peter Ujfalusi [this message]
2016-09-30 7:02 ` [PATCH 1/2] backlight: pwm_bl: Move the checks for initial power state to a separate function Peter Ujfalusi
2016-10-26 12:12 ` Lee Jones
2016-10-26 13:02 ` Peter Ujfalusi
2016-10-27 7:18 ` Peter Ujfalusi
2016-09-30 7:02 ` [PATCH 2/2] backlight: pwm_bl: Check the pwm state for initial backlight power state Peter Ujfalusi
2016-10-26 12:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930070259.5710-1-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®