From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932934AbcI3MeI (ORCPT <rfc822;w@1wt.eu>);
        Fri, 30 Sep 2016 08:34:08 -0400
Received: from mx2.suse.de ([195.135.220.15]:52706 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932224AbcI3MeA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 30 Sep 2016 08:34:00 -0400
Date: Fri, 30 Sep 2016 14:33:57 +0200
From: Johannes Thumshirn <jthumshirn@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Solomon Peachy <pizza@shaftnet.org>, Kalle Valo <kvalo@codeaurora.org>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] cw1200: Don't leak memory if krealloc failes
Message-ID: <20160930123357.iatuxcbki2r5dce3@linux-x5ow.site>
References: <1475237495-15030-1-git-send-email-jthumshirn@suse.de>
 <1475238579.17481.56.camel@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1475238579.17481.56.camel@sipsolutions.net>
User-Agent: Mutt/1.6.2 (2016-07-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 30, 2016 at 02:29:39PM +0200, Johannes Berg wrote:
> 
> > +	tmp = krealloc(buf->begin, size, GFP_KERNEL | GFP_DMA);
> > +	if (tmp) {
> > 
> I think that check is inverted?
> 
> johannes

Fu.. you're right, of cause it's !tmp.

I'll resend.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850