mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: "Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>, David Airlie <airlied@linux.ie>,
	Jammy Zhou <Jammy.Zhou@amd.com>, Rex Zhu <Rex.Zhu@amd.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/amdgpu: enable powerplay unconditionally
Date: Fri, 30 Sep 2016 18:20:56 +0200	[thread overview]
Message-ID: <20160930162134.158641-1-arnd@arndb.de> (raw)

Using the newly exported amd_set_clockgating_by_smu function in the main amdgpu driver
means that we can no longer build the driver without also enabling the powerplay
component, otherwise we get this link error:

ERROR: "amd_set_clockgating_by_smu" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

The easiest way to avoid this error is to always enable the Kconfig symbol when
the amdgpu driver is enabled.

Fixes: a8ca34136453 ("drm/amdgpu: set gfx clock gating for tonga/polaris.")
Fixes: 1bb08f91b0f6 ("drm/amdgpu: set system clock gating for tonga/polaris.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
It's quite likely that there is a better way to do this, as the separation
of the drivers is intentional. If my patch isn't acceptable, please come
up with a different solution.
---
 drivers/gpu/drm/amd/powerplay/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/Kconfig b/drivers/gpu/drm/amd/powerplay/Kconfig
index af380335b425..6d4f155a0453 100644
--- a/drivers/gpu/drm/amd/powerplay/Kconfig
+++ b/drivers/gpu/drm/amd/powerplay/Kconfig
@@ -1,6 +1,4 @@
 config DRM_AMD_POWERPLAY
-	bool  "Enable AMD powerplay component"
-	depends on DRM_AMDGPU
-	default n
+	def_bool DRM_AMDGPU
 	help
 	  select this option will enable AMD powerplay component.
-- 
2.9.0

             reply	other threads:[~2016-09-30 16:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-30 16:20 Arnd Bergmann [this message]
2016-09-30 16:26 ` Deucher, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160930162134.158641-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=Jammy.Zhou@amd.com \
    --cc=Rex.Zhu@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®