From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933753AbcI3OaP (ORCPT ); Fri, 30 Sep 2016 10:30:15 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:52474 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932968AbcI3OaE (ORCPT ); Fri, 30 Sep 2016 10:30:04 -0400 From: Arnd Bergmann To: Baoyou Xie Subject: Re: [PATCH 1/2] qed: mark symbols static where possible Date: Fri, 30 Sep 2016 16:29:39 +0200 User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; ) Cc: Yuval.Mintz@qlogic.com, Ariel.Elior@qlogic.com, everest-linux-l2@qlogic.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn References: <1475222189-19092-1-git-send-email-baoyou.xie@linaro.org> In-Reply-To: <1475222189-19092-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201609301629.39922.arnd@arndb.de> X-Provags-ID: V03:K0:0nDPKqm1Ufr5NuRUiWr2h933ddYlupsjEdDmBiMISMeJh6jVbxO 5F/5e3OgxM7+bvqLGkeGP5JSK32WbID30F7cFdwZskE4bds/sITDRTctlFYq2WFeczT6KAe YYB2erzDXmKVusE6c1OWX1LKGS3/+MpopkDmsmTsRg4bOUp2DaBusjhPvMsEtFMJBK+L1J4 EWEb6TIzLfUhVSVDZRHPw== X-UI-Out-Filterresults: notjunk:1;V01:K0:67xD6Y9LBSg=:buELoCmUGCkLO9IKBLFzBy Kqzll5RmXyy7D8RC/ej3jGBftydIbqoaJmTJUyhTx9xvl20CL63a9uH9a9CwJWyYdLowoOW7v 5KIkVIBSllu0pgzKHiF89vhlpe1xwzN9obUC2ACYdYSpmfFgDy4BCXfl++y9bNr2FjrzETVEQ GhvO154ei+ZRq7jng9Zd3X3M98IcjLm7MioLWaScK5R4BDX3rylxMt0We1wl30JiJ9yEzPaD7 o1qcKmjeg66KCl73H/ZmvPE8DwCjsQh+WIiJs6ZEKUi/W7wJFKlkbLOmUlDHN12NbkdMhZRmp sRn8tswaAMLGXDUt3ct1I33bs9AneqqRBFy/TTF2o7OIcvnjX4vv45iYP9RiLoaim9H/GQCys vJnyY09GRVYYKQnIidVquBXH/rCem4GrVVbXRIK9L2dOEk5UMmfVtWk1ORidPWhcE7Su0SnGs N/gCTlqa72jIqPoO5FhPjm6feycfoZGXtVqWnzvn7bLA+mH+vwiIakXjvDzptC3EIX9f5FrAL UgJr7VHhfanVbtySaqSQ4D1D4I7WFErm8P/Vv87q/e9Wd12z1a4s6EG3T/S2R71VHKO8hSNmr R3GTXEIqhS2xjjKEtAcgBI14QtvWz2KK0LpKLMGxf6lBDbd5oDnHFsDNWZQ/HDcDnM73AuObU aFRCHMV8KzzP4xT41t6wbmGZFazWUSfPHUQ0k+2dLVK6u64KeRCEA+oV+pEPvFcs+VbFwwIJ/ 4BjZuUH/LFEDsHIk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 30 September 2016, Baoyou Xie wrote: > > We get 12 warnings when building kernel with W=1: > drivers/net/ethernet/qlogic/qed/qed_cxt.c:346:6: warning: no previous prototype for 'qed_cxt_set_srq_count' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_cxt.c:353:5: warning: no previous prototype for 'qed_cxt_get_srq_count' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_cxt.c:389:5: warning: no previous prototype for 'qed_cxt_get_proto_cid_start' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_cxt.c:395:5: warning: no previous prototype for 'qed_cxt_get_proto_tid_count' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_cxt.c:1801:6: warning: no previous prototype for 'qed_rdma_set_pf_params' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:4031:17: warning: no previous prototype for 'qed_mcp_trace_dump' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:4133:17: warning: no previous prototype for 'qed_reg_fifo_dump' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:4195:17: warning: no previous prototype for 'qed_igu_fifo_dump' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:4258:17: warning: no previous prototype for 'qed_protection_override_dump' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:6342:17: warning: no previous prototype for 'qed_print_idle_chk_results_wrapper' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:6416:17: warning: no previous prototype for 'format_feature' [-Wmissing-prototypes] > drivers/net/ethernet/qlogic/qed/qed_debug.c:6483:17: warning: no previous prototype for 'qed_dbg_dump' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie Acked-by: Arnd Bergmann