From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933642AbcI3Odm (ORCPT ); Fri, 30 Sep 2016 10:33:42 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:55086 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932968AbcI3Odd (ORCPT ); Fri, 30 Sep 2016 10:33:33 -0400 From: Arnd Bergmann To: Baoyou Xie Subject: Re: [PATCH 2/2] net: hns: add missing function declaration Date: Fri, 30 Sep 2016 16:32:24 +0200 User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; ) Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net, huangdaode@hisilicon.com, lisheng011@huawei.com, xieqianqian@huawei.com, fabf@skynet.be, oulijun@huawei.com, vinod.koul@intel.com, lipeng321@huawei.com, andrew@lunn.ch, tremyfr@gmail.com, chenny.xu@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn References: <1475221315-18602-1-git-send-email-baoyou.xie@linaro.org> In-Reply-To: <1475221315-18602-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201609301632.24678.arnd@arndb.de> X-Provags-ID: V03:K0:5Pn8ojLBXCWswoRj3RnQRlM3P/56qZNnkpyn5VxAbiX3nx0Qxzu Vn0dBv5E70HIIgluiybndbH+wKxri5jHjG+jwiPMNbBE6WTHXc6n7b+YKDwDqh1UIGXGhV0 matrc2a08CV6T7b36z6gVfFyMTSf1NREag9BD2SQCR4RxAipo5S32wWAzoNLDQhDxSi0Dpd 6NSOtcU/dThQdCAOlzkcQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Dw52q5exvo0=:+5N6X0e/pvLe2A7InJDAzi pbEH9iSiTqsFDa5PXsN+PuljpZojGgSjxy6Frl9oltZSgUSrCpvjR2PU6mNxxvW7Av7P3qca3 9tlgzSm5duTXjGX/0fPryNhHgZVB2w3+XaSM2Z8bU81H4OYOm1Da1seFvxCdvsefoNy154viR 4x9woue6HIAQfgkHJden2H/YqzlqWFjjNeM4GnIHsRgZfs3PZ3ioN4qsrh0K8pxBJy76zm+9A zBRkCgh3DKAhzjleRnn75QvCknnutlE97+TGv+HQ0iE6niJBkWTM5YxI2Q+6zjqzoEH2KyejH IEeREsOJ5ympTtx4vxtWeof7+wvgR40xqJFXJR+Xw8QYrBSip0fVNjIf9ynOveSMDCePaoa8J 91jwHbdSVheZzU8wh6/T+sGq1vruckpdOxoyWSxXdJUukERQFMcm9QqjvUnpsQc2qvHm/9iqQ XnmSojTkT9Y2Wv9l6qCtASdm8H2MDCcgc7agXLNKy0xdFgo8tSknIMdt1BjAQn2k2L+0e4kYV tNBQzplbJRrHDakjdEixU4p34RucWAUDgp/mAX2D1I9Bw31so4ERm6VncU7jsV8X/R9jQI1Ra CreP1vvK+pBdChKGR5jhidWl6cqFMAOFs+BX0kmn22XFsoSBFEdfx9kADnLzFqVCHgo3Q8BTh MRMC8/T44zkIsxkkv6LYnpEUBt3LZqn9lZeeo1x5Vqgg4RSlayhJ84aJLf85Zg4TdP8D7tHMU aqk27VPFHhg2oko+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 30 September 2016, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2784:5: warning: no previous prototype for 'hns_dsaf_roce_reset' [-Wmissing-prototypes] > > In fact, this function is not declared in any file, but should be > declared in a header file. thus can be recognized in other file. > > so this patch adds the missing function declaration into > drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h. > > Signed-off-by: Baoyou Xie If you get to a case like this, please describe in the changelog how you determined that the function is there intentionally, rather than something that should be removed? I also see that you had sent the patch series for hns previously, and had included a 'v2' version in the subject, but left out the version this time. Please always use increasing version numbers when you send a new version of the series. Arnd