From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933843AbcI3OfM (ORCPT ); Fri, 30 Sep 2016 10:35:12 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:61645 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933050AbcI3OfD (ORCPT ); Fri, 30 Sep 2016 10:35:03 -0400 From: Arnd Bergmann To: Baoyou Xie Subject: Re: [PATCH 2/2] megaraid_sas: clean function declarations in megaraid_sas_fusion.c up Date: Fri, 30 Sep 2016 16:34:34 +0200 User-Agent: KMail/1.12.2 (Linux/4.7.0-rc7+; KDE/4.3.2; x86_64; ; ) Cc: kashyap.desai@avagotech.com, sumit.saxena@avagotech.com, uday.lingala@avagotech.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn References: <1475228702-21408-1-git-send-email-baoyou.xie@linaro.org> In-Reply-To: <1475228702-21408-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201609301634.34846.arnd@arndb.de> X-Provags-ID: V03:K0:AGY/JVY1CE4V2i3AE75dlNMznojSzylo9WSMZv21SsEDnwjAxoQ w49nKxn83SQRqrVy4nEXZBNDXHlhQYlIMPRlfYGpvKihqK8BI/QoJfDe0+7PN1qWzvRX2Du mnih0Jy+TKvkNpbyV7snPxMXVQXoA/tv5Sqj0UB8P2r+78RiPaV+MMozi748HpL0kLjtoa7 IZvQvPIY+Z9bfCsuMrPAQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:8UPAuKMj8ao=:eyF4EBxUxjgGyy0pgX++I4 1OLJc+DP4bI2e3mUJrPiVSgak3nLXi8WQP28sua8aYf9HBpT6bcl0QQQ1i417PfVLiTvCVQt2 eGBkPOoWbQaDDcxV/QJ0tlFxGvEocrur5QTCZYlCj6hef2qa3kdt+z5Egfw9DcVfosfo1AIx2 7avHvR47z2d8Fc/qYp5k4WJ1Kl6dpNWLha/CuY7szIH5zrkYNo0dxI8u+8KTw6nidzAKPy7ky Rxk1cKxdcNhtsKkzE0EZII5evaAxqU9uqa4Z/L2mHG211SRqhFBO58aJdVTu32n3MeJpcf/X/ +DfPmFmEuYobmFYKeL8LJHnfRtlDJtUPGOK3MOpNNl9iOB/lFvHsji0T2EayLIZwL7bL7S3WY NK6JUx5K7Q201ktHRyWRAQp/GFLygFdYoRfhAHChM0zDIz7xuFAAHrk1JhvvhiGXbdwXb46mK QOfnjNPu62xwvtXvG6lRsMaAjayHo8kxmegxq8Jnf+CcHwhDKoSHi/O/YWz84xKaFh4tP/cG2 tv8/O9DpYWVokGX2r+oIXz9U51RDbI3glagKAGlaqtDbIBxByuAWJ+BPYTOBaX8q2xkW7Q/od dv0zkvVNyd3O+R+nd+/0d8BioJw6It4v14PMIFxM2dwXVd7OysQW/9ntDXUOfZKeUR7GivMEo oGpM4NJQlz59CHgCHHCYKbGgbNOgcSw8V+052X6Hgju9/o2mgqFR2+tl9s+Lqv8e3Tmy/4ya6 XhqGxfxVcDHwwXC+ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 30 September 2016, Baoyou Xie wrote: > int megasas_transition_to_ready(struct megasas_instance *instance, int ocr); > -void megaraid_sas_kill_hba(struct megasas_instance *instance); > > extern u32 megasas_dbg_lvl; > -void megasas_sriov_heartbeat_handler(unsigned long instance_addr); > -int megasas_sriov_start_heartbeat(struct megasas_instance *instance, > - int initial); > -void megasas_start_timer(struct megasas_instance *instance, > - struct timer_list *timer, > - void *fn, unsigned long interval); > extern struct megasas_mgmt_info megasas_mgmt_info; > extern unsigned int resetwaittime; > extern unsigned int dual_qdepth_disable; I think you should remove all "extern" declarations from the .c file at the same time here, and move them to an appropriate header, or remove them in case the symbol is already gone and we only have the declaration left. Arnd