From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751316AbcJAHZS (ORCPT ); Sat, 1 Oct 2016 03:25:18 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:51994 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750845AbcJAHZR (ORCPT ); Sat, 1 Oct 2016 03:25:17 -0400 Date: Sat, 01 Oct 2016 03:25:04 -0400 (EDT) Message-Id: <20161001.032504.1254372735513201320.davem@davemloft.net> To: dmitry.torokhov@gmail.com Cc: tyhicks@canonical.com, serge.hallyn@ubuntu.com, james.l.morris@oracle.com, ebiederm@xmission.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: Use ns_capable_noaudit() when determining net sysctl permissions From: David Miller In-Reply-To: <20160930222431.GA30208@dtor-ws> References: <20160930222431.GA30208@dtor-ws> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 01 Oct 2016 00:25:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Torokhov Date: Fri, 30 Sep 2016 15:24:31 -0700 > From: Tyler Hicks > > The capability check should not be audited since it is only being used > to determine the inode permissions. A failed check does not indicate a > violation of security policy but, when an LSM is enabled, a denial audit > message was being generated. > > The denial audit message caused confusion for some application authors > because root-running Go applications always triggered the denial. To > prevent this confusion, the capability check in net_ctl_permissions() is > switched to the noaudit variant. > > BugLink: https://launchpad.net/bugs/1465724 > > Signed-off-by: Tyler Hicks > Acked-by: Serge E. Hallyn > Signed-off-by: James Morris > [dtor: reapplied after e79c6a4fc923 ("net: make net namespace sysctls > belong to container's owner") accidentally reverted the change.] > Signed-off-by: Dmitry Torokhov Applied, but please be clear in the future what tree a patch is targetting, in this case 'net-next'. You can indicate this in the Subject line "[PATCH net-next]".