From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: jiri@mellanox.com, idosch@mellanox.com, yotamg@mellanox.com,
nogahf@mellanox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mlxsw: spectrum_router: avoid potential uninitialized data usage
Date: Mon, 03 Oct 2016 01:56:08 -0400 (EDT) [thread overview]
Message-ID: <20161003.015608.1875283508445426057.davem@davemloft.net> (raw)
In-Reply-To: <20160930161734.70928-2-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 30 Sep 2016 18:17:10 +0200
> If fi->fib_nhs is zero, the router interface pointer is uninitialized, as shown by
> this warning:
>
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c: In function 'mlxsw_sp_router_fib_event':
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:1674:21: error: 'r' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c:1643:23: note: 'r' was declared here
>
> This changes the loop so we handle the case the same way as finding no router
> interface pointer attached to one of the nexthops to ensure we always
> trap here instead of using uninitialized data.
>
> Fixes: b45f64d16d45 ("mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied.
next prev parent reply other threads:[~2016-10-03 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 16:17 [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning Arnd Bergmann
2016-09-30 16:17 ` [PATCH 2/2] mlxsw: spectrum_router: avoid potential uninitialized data usage Arnd Bergmann
2016-09-30 17:57 ` Ido Schimmel
2016-10-01 3:36 ` Arnd Bergmann
2016-10-03 5:56 ` David Miller [this message]
2016-10-01 15:08 ` [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning Or Gerlitz
2016-10-03 5:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003.015608.1875283508445426057.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nogahf@mellanox.com \
--cc=yotamg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®