From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbcJCKey (ORCPT ); Mon, 3 Oct 2016 06:34:54 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:55416 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751986AbcJCKex (ORCPT ); Mon, 3 Oct 2016 06:34:53 -0400 From: Colin King To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Alexander Shishkin , Masami Hiramatsu , Ravi Bangoria , Wang Nan Cc: linux-kernel@vger.kernel.org Subject: [PATCH] perf probe: check if *ptr2 is zero and not ptr2 Date: Mon, 3 Oct 2016 11:34:31 +0100 Message-Id: <20161003103431.18534-1-colin.king@canonical.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Static anaylsis with cppcheck detected an incorrect comparison: [tools/perf/util/probe-event.c:216]: (warning) Char literal compared with pointer 'ptr2'. Did you intend to dereference it? Dereference ptr2 for the comparison to fix this. Fixes: 35726d3a4ca9 ("perf probe: Fix to cut off incompatible chars from group name") Signed-off-by: Colin Ian King --- tools/perf/util/probe-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index fcfbef0..d281ae2 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -213,7 +213,7 @@ static int convert_exec_to_group(const char *exec, char **result) goto out; } - for (ptr2 = ptr1; ptr2 != '\0'; ptr2++) { + for (ptr2 = ptr1; *ptr2 != '\0'; ptr2++) { if (!isalnum(*ptr2) && *ptr2 != '_') { *ptr2 = '\0'; break; -- 2.9.3