From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752728AbcJCSq5 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 3 Oct 2016 14:46:57 -0400
Received: from mail-oi0-f68.google.com ([209.85.218.68]:34442 "EHLO
        mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751549AbcJCSqr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 3 Oct 2016 14:46:47 -0400
Date: Mon, 3 Oct 2016 13:46:45 -0500
From: Rob Herring <robh@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: open list <linux-kernel@vger.kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@linux.ie>, Mark Rutland <mark.rutland@arm.com>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        Gustaf =?iso-8859-1?Q?Lindstr=F6m?= <gl@axentia.se>
Subject: Re: [PATCH v3 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel
 binding
Message-ID: <20161003184645.GA23584@rob-hp-laptop>
References: <1474928832-8766-1-git-send-email-peda@axentia.se>
 <1474928832-8766-2-git-send-email-peda@axentia.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1474928832-8766-2-git-send-email-peda@axentia.se>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 27, 2016 at 12:27:11AM +0200, Peter Rosin wrote:
> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel.
> 
> Signed-off-by: Peter Rosin <peda@axentia.se>
> ---
>  .../bindings/display/panel/sharp,lq150x1lg11.txt   | 36 ++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
> new file mode 100644
> index 000000000000..715ff7e332f2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt
> @@ -0,0 +1,36 @@
> +Sharp 15" LQ150X1LG11 XGA TFT LCD panel
> +
> +Required properties:
> +- compatible: should be "sharp,lq150x1lg11"
> +- power-supply: regulator to provide the VCC supply voltage (3.3 volts)

Should be named according to the input, so vcc-supply.

> +
> +Optional properties:
> +- backlight: phandle of the backlight device
> +- rlud-gpios: a single GPIO for the RL/UD (rotate 180 degrees) pin.
> +- lvds-gpios: a single GPIO for the SELLVDS pin.

Why not sellvds-gpios?

> +
> +If lrud-gpios and/or ldvs-gpios are not specified, the RL/UD and/or SELLVDS

typos...

> +pins are assumed to be handled appropriately by the hardware.
> +
> +Example:
> +
> +	backlight: backlight {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm 0 100000>;                      /* VBR */
> +
> +		brightness-levels = <0 20 40 60 80 100>;
> +		default-brightness-level = <2>;
> +
> +		power-supply = <&vdd_12v_reg>;               /* VDD */
> +		enable-gpios = <&gpio 42 GPIO_ACTIVE_HIGH>;  /* XSTABY */
> +	};
> +
> +	panel {
> +		compatible = "sharp,lq150x1lg11";
> +
> +		power-supply = <&vcc_3v3_reg>;               /* VCC */
> +
> +		backlight = <&backlight>;
> +		rlud-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;    /* RL/UD */
> +		lvds-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;    /* SELLVDS */
> +	};
> -- 
> 2.1.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html