From: Darren Hart <dvhart@infradead.org>
To: SeongJae Park <sj38.park@gmail.com>
Cc: shuah@kernel.org, dvhart@linux.intel.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/futex: Check ANSI terminal color support
Date: Mon, 3 Oct 2016 15:02:53 -0700 [thread overview]
Message-ID: <20161003220253.GA3071@f23x64.localdomain> (raw)
In-Reply-To: <20161002020218.19622-1-sj38.park@gmail.com>
On Sun, Oct 02, 2016 at 11:02:18AM +0900, SeongJae Park wrote:
> Because test for color support of the running shell does not aware ANSI
> type terminals, it does not print colorful messages on some environemnt.
> This commit modifies the test to aware ANSI type terminal, too.
>
> Signed-off-by: SeongJae Park <sj38.park@gmail.com>
No objection. Terminfo slists these separately, and I don't see a way to handle
ANSI in a single command.
Acked-by: Darren Hart <dvhart@linux.intel.com>
> ---
> tools/testing/selftests/futex/functional/run.sh | 2 +-
> tools/testing/selftests/futex/run.sh | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/futex/functional/run.sh b/tools/testing/selftests/futex/functional/run.sh
> index e87dbe2a0b0d..7ff002eed624 100755
> --- a/tools/testing/selftests/futex/functional/run.sh
> +++ b/tools/testing/selftests/futex/functional/run.sh
> @@ -24,7 +24,7 @@
>
> # Test for a color capable console
> if [ -z "$USE_COLOR" ]; then
> - tput setf 7
> + tput setf 7 || tput setaf 7
> if [ $? -eq 0 ]; then
> USE_COLOR=1
> tput sgr0
> diff --git a/tools/testing/selftests/futex/run.sh b/tools/testing/selftests/futex/run.sh
> index 4126312ad64e..88bcb1767362 100755
> --- a/tools/testing/selftests/futex/run.sh
> +++ b/tools/testing/selftests/futex/run.sh
> @@ -23,7 +23,7 @@
>
> # Test for a color capable shell and pass the result to the subdir scripts
> USE_COLOR=0
> -tput setf 7
> +tput setf 7 || tput setaf 7
> if [ $? -eq 0 ]; then
> USE_COLOR=1
> tput sgr0
> --
> 2.10.0
>
>
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2016-10-03 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 2:02 SeongJae Park
2016-10-03 22:02 ` Darren Hart [this message]
2016-10-10 23:15 ` SeongJae Park
2016-10-11 13:26 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003220253.GA3071@f23x64.localdomain \
--to=dvhart@infradead.org \
--cc=dvhart@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=sj38.park@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®