From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752958AbcJDH3C (ORCPT ); Tue, 4 Oct 2016 03:29:02 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:32996 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbcJDH3B (ORCPT ); Tue, 4 Oct 2016 03:29:01 -0400 Date: Tue, 4 Oct 2016 09:28:56 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Greg Kroah-Hartman Cc: Richard Genoud , Nicolas Ferre , Alexandre Belloni , Cyrille Pitchen , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCHv4 1/3] serial: mctrl_gpio: implement mctrl_gpio_use_rtscts Message-ID: <20161004072856.cgocbex2uj5f3yp4@pengutronix.de> References: <20160930085801.21497-1-richard.genoud@gmail.com> <20160930085801.21497-2-richard.genoud@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160930085801.21497-2-richard.genoud@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-06-11) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg, On Fri, Sep 30, 2016 at 10:57:59AM +0200, Richard Genoud wrote: > This function returns true if CTS and RTS are used as GPIOs. > Some drivers (like atmel_serial) needs to know if the flow control is > handled by the controller or by GPIOs. just for the record: I don't like this patch because I think it's highly at91 specific and could so well live in that driver. Moreover I'm not conviced yet that it's really the correct thing to do even for this driver. So please don't apply, at least until we're done with the discussion of patch 2. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |