From: Guenter Roeck <linux@roeck-us.net>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "jdelvare@suse.com" <jdelvare@suse.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Wang <Michael.Wang@alliedtelesis.co.nz>
Subject: Re: [PATCHv1] hwmon: adm9240: handle temperature readings below 0
Date: Tue, 4 Oct 2016 15:09:38 -0700 [thread overview]
Message-ID: <20161004220938.GA4566@roeck-us.net> (raw)
In-Reply-To: <3c7c751bd9d24856ace5866ffb94060a@svr-chch-ex1.atlnz.lc>
On Tue, Oct 04, 2016 at 09:09:10PM +0000, Chris Packham wrote:
>
> >
> > Of course, all that doesn't solve the real problem in this driver, which is
> > that it ignores error codes from the smbus functions, but that is a different
> > problem.
>
> Yeah I'd noted that too. This patch is actually a port of changes we've
> made to a custom LM81 driver based on the original adm9240 driver which
> included some error handling. I'll look at bringing more of that code in
> for a future patch.
>
Sounds good...
Thanks,
Guenter
next prev parent reply other threads:[~2016-10-04 22:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 4:08 Chris Packham
2016-10-04 20:53 ` Guenter Roeck
2016-10-04 21:09 ` Chris Packham
2016-10-04 22:09 ` Guenter Roeck [this message]
2016-10-05 5:00 ` adm9240 error handling (was Re: [PATCHv1] hwmon: adm9240: handle temperature readings below 0) Chris Packham
2016-10-05 13:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004220938.GA4566@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=Michael.Wang@alliedtelesis.co.nz \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®