From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754433AbcJED1p (ORCPT ); Tue, 4 Oct 2016 23:27:45 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:35379 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbcJED1n (ORCPT ); Tue, 4 Oct 2016 23:27:43 -0400 Date: Wed, 5 Oct 2016 08:57:39 +0530 From: Viresh Kumar To: Markus Mayer Cc: Rob Herring , Mark Rutland , "Rafael J . Wysocki" , Broadcom Kernel List , Device Tree List , Power Management List , Linux Kernel Mailing List Subject: Re: [RESEND PATCH v2 3/3] cpufreq: brcmstb-avs-cpufreq: add debugfs support Message-ID: <20161005032739.GH4664@vireshk-i7> References: <1475272561-8446-1-git-send-email-mmayer@broadcom.com> <1475272561-8446-4-git-send-email-mmayer@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475272561-8446-4-git-send-email-mmayer@broadcom.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30-09-16, 14:56, Markus Mayer wrote: > In order to aid debugging, we add a debugfs interface to the driver > that allows direct interaction with the AVS co-processor. > > The debugfs interface provides a means for reading all and writing some > of the mailbox registers directly from the shell prompt and enables a > user to execute the communications protocol between ARM CPU and AVS CPU > step-by-step. > > This interface should be used for debugging purposes only. > > Signed-off-by: Markus Mayer > --- > drivers/cpufreq/brcmstb-avs-cpufreq.c | 319 ++++++++++++++++++++++++++++++++++ > 1 file changed, 319 insertions(+) I am not sure how much useful this is going to be, but I don't have any concerns against this as well. Acked-by: Viresh Kumar -- viresh