From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936343AbcJGAte (ORCPT ); Thu, 6 Oct 2016 20:49:34 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:43404 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749AbcJGAt0 (ORCPT ); Thu, 6 Oct 2016 20:49:26 -0400 Date: Thu, 06 Oct 2016 20:49:23 -0400 (EDT) Message-Id: <20161006.204923.1914066918563386131.davem@davemloft.net> To: mike.looijmans@topic.nl Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, andrew@lunn.ch, f.fainelli@gmail.com Subject: Re: [PATCH] devicetree: net: micrel-ksz90x1.txt: Properly explain skew settings From: David Miller In-Reply-To: <1475676188-10639-1-git-send-email-mike.looijmans@topic.nl> References: <1475676188-10639-1-git-send-email-mike.looijmans@topic.nl> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Oct 2016 17:49:25 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Looijmans Date: Wed, 5 Oct 2016 16:03:08 +0200 > The KSZ9031 skew registers contain an offset, the chip's default value > is "neutral" which does not add any skew. Programming a 0 into a skew > property will actually set it the maximal negative adjustment and not > to a neutral position as one would expect. > > Explain this situation in the devicetree binding documentation and list > the settings that the chip considers neutral. > > Changing the implementation to accept negative values would have been > a better solution, but would break existing configurations. > > Signed-off-by: Mike Looijmans Applied.