From: Greg KH <gregkh@linuxfoundation.org>
To: Samuele Baisi <ciccio87@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: lprocfs_status.h: fix sparse error: symbol redeclared with different type
Date: Fri, 7 Oct 2016 05:55:32 +0200 [thread overview]
Message-ID: <20161007035532.GC16832@kroah.com> (raw)
In-Reply-To: <20161006165207.30061-1-ciccio87@gmail.com>
On Thu, Oct 06, 2016 at 06:52:07PM +0200, Samuele Baisi wrote:
> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1554:5: error:
> symbol 'lprocfs_wr_root_squash' redeclared with different type (originally
> declared at drivers/staging/lustre/lustre/obdclass/../include/lprocfs_status.h:704)
> - incompatible argument 1 (different address spaces)
>
> drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1618:5: error:
> symbol 'lprocfs_wr_nosquash_nids' redeclared with different type (originally
> declared at drivers/staging/lustre/lustre/obdclass/../include/lprocfs_status.h:706)
> - incompatible argument 1 (different address spaces)
>
> Added __user annotation to the header definitions arguments (which are
> indeed userspace buffers).
Are they really? Have you tested this? The last time this was looked
at, it was a non-trivial problem...
And any reason you didn't cc the lustre maintainers with this change?
If you think it is correct, please resend it with the testing
information and cc: them.
thanks,
greg k-h
next prev parent reply other threads:[~2016-10-07 4:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 16:52 Samuele Baisi
2016-10-07 3:55 ` Greg KH [this message]
2016-10-07 8:29 ` Samuele Baisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007035532.GC16832@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ciccio87@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome