From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Debjit Ghosh <dghosh@juniper.net>,
Georgi Vlaev <gvlaev@juniper.net>,
Guenter Roeck <linux@roeck-us.net>,
Mohammad Kamil <mkamil@juniper.net>,
Rajat Jain <rajatjain@juniper.net>,
Shyamshankar Dharmarajan <shyamd@juniper.net>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h
Date: Fri, 7 Oct 2016 17:31:16 +0200 [thread overview]
Message-ID: <20161007153116.GD10482@kroah.com> (raw)
In-Reply-To: <1475853346-21890-3-git-send-email-pantelis.antoniou@konsulko.com>
On Fri, Oct 07, 2016 at 06:15:46PM +0300, Pantelis Antoniou wrote:
> From: Rajat Jain <rajatjain@juniper.net>
>
> Add this header to contain the PCI device IDs that we cannot add in
> the linux pci_ids.h.
Why can't you?
> This would contain PCI device IDs of Juniper devices as well as any
> PCIe switches etc.
Why do you need a .h file for this? Is the values in it shared across
drivers? If not, you don't nee a .h file at all. If so, then it
belongs in pci_ids.h as the top of that file describes.
thanks,
greg k-h
next prev parent reply other threads:[~2016-10-07 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 15:15 [PATCH 0/2] Juniper infrastructure Pantelis Antoniou
2016-10-07 15:15 ` [PATCH 1/2] staging: jnx: Juniper subsystem & board core APIs Pantelis Antoniou
2016-10-07 15:34 ` Greg Kroah-Hartman
2016-10-07 15:15 ` [PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h Pantelis Antoniou
2016-10-07 15:31 ` Greg Kroah-Hartman [this message]
2016-10-07 15:28 ` [PATCH 0/2] Juniper infrastructure Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007153116.GD10482@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=dghosh@juniper.net \
--cc=gvlaev@juniper.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mkamil@juniper.net \
--cc=pantelis.antoniou@konsulko.com \
--cc=rajatjain@juniper.net \
--cc=shyamd@juniper.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome