mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dave Young <dyoung@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Kees Cook <keescook@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: Re: Change CONFIG_DEVKMEM default value to n
Date: Mon, 10 Oct 2016 07:12:39 +0200	[thread overview]
Message-ID: <20161010051239.GA22781@kroah.com> (raw)
In-Reply-To: <20161010025050.GA3776@dhcp-128-65.nay.redhat.com>

On Mon, Oct 10, 2016 at 10:50:50AM +0800, Dave Young wrote:
> On 10/10/16 at 10:44am, Dave Young wrote:
> > On 10/07/16 at 05:57am, Greg Kroah-Hartman wrote:
> > > On Fri, Oct 07, 2016 at 10:04:11AM +0800, Dave Young wrote:
> > > > Kconfig comment suggests setting it as "n" if in doubt thus move the
> > > > default value to 'n'.
> > > > 
> > > > Signed-off-by: Dave Young <dyoung@redhat.com>
> > > > Suggested-by: Kees Cook <keescook@chromium.org>
> > > > ---
> > > >  drivers/char/Kconfig |    2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > --- linux-x86.orig/drivers/char/Kconfig
> > > > +++ linux-x86/drivers/char/Kconfig
> > > > @@ -17,7 +17,7 @@ config DEVMEM
> > > >  
> > > >  config DEVKMEM
> > > >  	bool "/dev/kmem virtual device support"
> > > > -	default y
> > > > +	default n
> > > 
> > > If you remove the "default" line, it defaults to 'n'.
> > 
> > I personally perfer a "default n", but I can update it..
> 
> Greg, here is an update with dropping the default line:

<snip>

Can you resend it in a format I can apply it in?

thanks,

greg k-h

  reply	other threads:[~2016-10-10  5:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07  2:04 Dave Young
2016-10-07  3:57 ` Greg Kroah-Hartman
2016-10-07 17:02   ` Kees Cook
2016-10-10  2:44   ` Dave Young
2016-10-10  2:50     ` Dave Young
2016-10-10  5:12       ` Greg Kroah-Hartman [this message]
2016-10-10  5:35         ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161010051239.GA22781@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=dyoung@redhat.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome