From: Arnd Bergmann <arnd@arndb.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] dmaengine: mmp_tdma: select GENERIC_ALLOCATOR
Date: Mon, 10 Oct 2016 14:07:35 +0200 [thread overview]
Message-ID: <20161010120839.905144-1-arnd@arndb.de> (raw)
build testing on x86 revealed a missing dependency that leads to a link error:
drivers/dma/built-in.o: In function `mmp_tdma_prep_dma_cyclic':
mmp_tdma.c:(.text+0x9564): undefined reference to `gen_pool_dma_alloc'
drivers/dma/built-in.o: In function `mmp_tdma_free_chan_resources':
mmp_tdma.c:(.text+0x9675): undefined reference to `gen_pool_free'
drivers/dma/built-in.o: In function `mmp_tdma_probe':
mmp_tdma.c:(.text+0x9854): undefined reference to `of_gen_pool_get'
This adds a 'select' statement to the driver to get it to build cleanly.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/dma/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index af63a6bcf564..d882eb0fa551 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -305,6 +305,7 @@ config MMP_TDMA
bool "MMP Two-Channel DMA support"
depends on ARCH_MMP || COMPILE_TEST
select DMA_ENGINE
+ select GENERIC_ALLOCATOR
select MMP_SRAM if ARCH_MMP
help
Support the MMP Two-Channel DMA engine.
--
2.9.0
next reply other threads:[~2016-10-10 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 12:07 Arnd Bergmann [this message]
2016-10-18 15:05 ` Vinod Koul
2016-11-03 12:36 [PATCH] dmaengine: mmp_tdma: Select GENERIC_ALLOCATOR Borislav Petkov
2016-11-14 5:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010120839.905144-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®