From: Andrew Morton <akpm@linux-foundation.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrey Konovalov <andreyknvl@google.com>,
Nicolai Stange <nicstange@gmail.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Kees Cook <keescook@chromium.org>,
James Morse <james.morse@arm.com>,
LKML <linux-kernel@vger.kernel.org>,
Vegard Nossum <vegard.nossum@oracle.com>,
Quentin Casasnovas <quentin.casasnovas@oracle.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>
Subject: Re: [PATCH v2] kcov: properly check if we are in an interrupt
Date: Mon, 10 Oct 2016 16:32:34 -0700 [thread overview]
Message-ID: <20161010163234.d352d340f0bb1f28e727a9ad@linux-foundation.org> (raw)
In-Reply-To: <CACT4Y+bPjRUGTiemcbbdC8MOXU0GFFNw_zXiPhCWtJHRwZ_5zA@mail.gmail.com>
On Mon, 10 Oct 2016 19:19:11 +0200 Dmitry Vyukov <dvyukov@google.com> wrote:
> On Mon, Oct 10, 2016 at 6:10 PM, Andrey Konovalov <andreyknvl@google.com> wrote:
> > in_interrupt() returns a nonzero value when we are either in an
> > interrupt or have bh disabled via local_bh_disable(). Since we are
> > interested in only ignoring coverage from actual interrupts, do a
> > proper check instead of just calling in_interrupt().
> >
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
>
> FWIW
> Acked-by: Dmitry Vyukov <dvyukov@google.com>
>
> This fixes a very real problem for us.
> As per discussion in v1, other solution would involve auditing all
> uses of in_interrupt() which needs knowledge about all drivers.
OK, but I'm not seeing a description of what the problem *is*. Could
we please have a complete description of the user-visible effects of this
change, for the changelog?
next prev parent reply other threads:[~2016-10-10 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 16:10 Andrey Konovalov
2016-10-10 17:19 ` Dmitry Vyukov
2016-10-10 23:32 ` Andrew Morton [this message]
2016-10-11 15:06 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010163234.d352d340f0bb1f28e727a9ad@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=james.morse@arm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicstange@gmail.com \
--cc=quentin.casasnovas@oracle.com \
--cc=ryabinin.a.a@gmail.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome