mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Shyam Saini <mayhs11saini@gmail.com>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages()
Date: Tue, 11 Oct 2016 10:15:34 +0200	[thread overview]
Message-ID: <20161011081534.GY20761@phenom.ffwll.local> (raw)
In-Reply-To: <1476064367.14200.0.camel@gmail.com>

On Mon, Oct 10, 2016 at 07:22:47AM +0530, Shyam Saini wrote:
> On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote:
> > On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini <mayhs11saini@gmail.com>
> > wrote:
> > > 
> > > Replace explicit computation of vma page count by a call to
> > > vma_pages()
> > Hi, I already have this patch in the "queue" from:
> > Muhammad Falak R Wani <falakreyaz@gmail.com>
> > 
> > Will include that one when I get around to sending out a PR.

Since the merge window is pretty much done I've applied this one here to
drm-misc to make sure it wont get lost.
-Daniel

> > 
> > Thanks
> > Patrik
> > 
> > > 
> > > 
> > > Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
> > > ---
> > >  drivers/gpu/drm/gma500/framebuffer.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/gma500/framebuffer.c
> > > b/drivers/gpu/drm/gma500/framebuffer.c
> > > index 3a44e70..0fde850 100644
> > > --- a/drivers/gpu/drm/gma500/framebuffer.c
> > > +++ b/drivers/gpu/drm/gma500/framebuffer.c
> > > @@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct
> > > *vma, struct vm_fault *vmf)
> > >         unsigned long phys_addr = (unsigned long)dev_priv-
> > > >stolen_base +
> > >                                   psbfb->gtt->offset;
> > > 
> > > -       page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > > +       page_num = vma_pages(vma);
> > >         address = (unsigned long)vmf->virtual_address - (vmf->pgoff 
> > > << PAGE_SHIFT);
> > > 
> > >         vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> > > --
> > > 2.7.4
> > > 
> 
> No issue.
> 
> Thanks
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2016-10-11  8:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-09 23:07 Shyam Saini
2016-10-09 23:46 ` Patrik Jakobsson
2016-10-10  1:52   ` Shyam Saini
2016-10-11  8:15     ` Daniel Vetter [this message]
2016-10-11  8:50       ` Patrik Jakobsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161011081534.GY20761@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mayhs11saini@gmail.com \
    --cc=patrik.r.jakobsson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome