From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754075AbcJKQtm (ORCPT ); Tue, 11 Oct 2016 12:49:42 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:58320 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754011AbcJKQtk (ORCPT ); Tue, 11 Oct 2016 12:49:40 -0400 Date: Tue, 11 Oct 2016 09:49:38 -0700 From: Christoph Hellwig To: Johannes Thumshirn Cc: "Martin K . Petersen" , Christoph Hellwig , Hannes Reinecke , Linux Kernel Mailinglist , Linux SCSI Mailinglist Subject: Re: [PATCH 00/44] Convert FibreChannel bsg code to use bsg-lib Message-ID: <20161011164938.GA6083@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Johannes, this looks great to me. But is there a chance to consolidate it into a more manageable set of patches? E.g. all the patches to call export fc_bsg_jobdone, use it directly and remove the function pointer could go together, possibly even including the new calling convention. Similar all the patches about fc_bsg_to_shost could be merged into one, and if we add the bsg refcounting early, we could maybe skip a few steps of the conversion later on?